Sign upLogin

thooams/ui_bibz

View on GitHub
Star

Showing 23 of 46 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  clearSearch() {
    $('.clear-search-btn', this.node).click(function() {
      $(this).parents('form').find('input[type=search]').val('')
      $(this).parents('form').submit()
    })
Severity: Major
Found in app/assets/javascripts/tables.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/tables.js on lines 13..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 86.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  submitPerPageSelect() {
    $('.table-pagination-per-page select', this.node).change(function() {
      $(this).parents('form').find('input[name=link_type]').val('per_page')
      $(this).parents('form').submit()
    })
Severity: Major
Found in app/assets/javascripts/tables.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/tables.js on lines 20..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 86.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function inputConnected has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    return $.fn.inputConnected = function(options) {
      var defaults, self, settings;
      defaults = {
        mode: "remote",
        events: "change",
Severity: Major
Found in app/assets/javascripts/forms/input-connected.js - About 2 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        let value = (100/(parseInt(this.max)-parseInt(this.min)))*parseInt(this.value)-(100/(parseInt(this.max)-parseInt(this.min)))*parseInt(this.min)
Severity: Major
Found in app/assets/javascripts/forms.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/forms.js on lines 139..139

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        let value = (100/(parseInt(this.max)-parseInt(this.min)))*parseInt(this.value)-(100/(parseInt(this.max)-parseInt(this.min)))*parseInt(this.min)
Severity: Major
Found in app/assets/javascripts/forms.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/forms.js on lines 150..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    afterSelect: function() {
      if (this.qs1 != null) {
        this.qs1.cache();
      }
      if (this.qs2 != null) {
Severity: Major
Found in app/assets/javascripts/forms/jquery.multi-select-extend.js and 1 other location - About 1 hr to fix
app/assets/javascripts/forms/jquery.multi-select-extend.js on lines 44..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    afterDeselect: function() {
      if (this.qs1 != null) {
        this.qs1.cache();
      }
      if (this.qs2 != null) {
Severity: Major
Found in app/assets/javascripts/forms/jquery.multi-select-extend.js and 1 other location - About 1 hr to fix
app/assets/javascripts/forms/jquery.multi-select-extend.js on lines 36..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function go has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  go(ch) {
    let i;
    const me = this;
    let flag = 0;
    for (i in me.rg2) {
Severity: Minor
Found in app/assets/javascripts/forms/formula.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        that.qs1 = $selectableSearch.quicksearch(selectableSearchString).on("keydown", function(e) {
          if (e.which === 40) {
            that.$selectableUl.focus();
            return false;
          }
Severity: Major
Found in app/assets/javascripts/forms/jquery.multi-select-extend.js and 1 other location - About 1 hr to fix
app/assets/javascripts/forms/jquery.multi-select-extend.js on lines 25..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        return that.qs2 = $selectionSearch.quicksearch(selectionSearchString).on("keydown", function(e) {
          if (e.which === 40) {
            that.$selectionUl.focus();
            return false;
          }
Severity: Major
Found in app/assets/javascripts/forms/jquery.multi-select-extend.js and 1 other location - About 1 hr to fix
app/assets/javascripts/forms/jquery.multi-select-extend.js on lines 19..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function doubleSlider has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  doubleSlider(){
    let me = this
    this.node.querySelectorAll(".slider").forEach(function(e){
      let slider = e
      let sliderId = slider.getAttribute("id")
Severity: Minor
Found in app/assets/javascripts/forms.js - About 1 hr to fix

Function constructor has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(){
    this.res = ""

    this.t = {
      x: "*",
Severity: Minor
Found in app/assets/javascripts/forms/formula.js - About 1 hr to fix

Function updateFormulaField has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  updateFormulaField(field) {
    let error, f, formulaAlert, formulaInputField, formulaResultField, formulaSignField, response, result
    formulaInputField = field
    formulaSignField = formulaInputField.siblings('.formula-field-sign')
    formulaResultField = formulaInputField.siblings('.formula-field-result')
Severity: Minor
Found in app/assets/javascripts/forms.js - About 1 hr to fix

Function go has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  go(ch) {
    let i;
    const me = this;
    let flag = 0;
    for (i in me.rg2) {
Severity: Minor
Found in app/assets/javascripts/forms/formula.js - About 1 hr to fix

Consider simplifying this complex logical expression.
Open

    if (((par1 != null) && (par2 != null) && (par1.length !== par2.length)) || ((par1 == null) && (par2 != null)) || ((par1 != null) && (par2 == null))) {
      return me.res = "Unclosed parenthesis.";
    } else if (/.*[\+x\*\/\-]$/.test(q)) {
      return me.res = "Formula ending with an operator.";
    } else {
Severity: Major
Found in app/assets/javascripts/forms/formula.js - About 1 hr to fix

Function afterInit has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    afterInit: function(ms) {
      var $selectableSearch, $selectionSearch, selectableSearchString, selectionSearchString, that;
      that = this;
      that.options.selectableOptgroup = $(this)[0].$element.data('selectableOptgroup') ? true : false;
      if ($(this)[0].$element.data('searchable')) {
Severity: Minor
Found in app/assets/javascripts/forms/jquery.multi-select-extend.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function constructor has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  constructor(node) {
    this.node = node || document
    if(node.querySelector('input.switch-field')){ this.setBootstrapSwitch() }
    if(node.querySelector('.ui-bibz-connect')) { this.inputConnected() }
    //if(node.querySelector('.dropdown-select-field')) { this.setMultiSelect() }
Severity: Minor
Found in app/assets/javascripts/forms.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function suite has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  suite(q) {
    const me   = this;
    const par1 = q.match(/\(/g);
    const par2 = q.match(/\)/g);
    if (((par1 != null) && (par2 != null) && (par1.length !== par2.length)) || ((par1 == null) && (par2 != null)) || ((par1 != null) && (par2 == null))) {
Severity: Minor
Found in app/assets/javascripts/forms/formula.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  class ModalHeader < UiBibz::Ui::Core::Component
    # See UiBibz::Ui::Core::Component.initialize

    # Render html tag
    def pre_render
Severity: Minor
Found in lib/ui_bibz/ui/core/windows/components/modal_header.rb and 1 other location - About 40 mins to fix
lib/ui_bibz/ui/core/windows/components/offcanvas_header.rb on lines 33..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  class OffcanvasHeader < UiBibz::Ui::Core::Component
    # See UiBibz::Ui::Core::Component.initialize

    # Render html tag
    def pre_render
Severity: Minor
Found in lib/ui_bibz/ui/core/windows/components/offcanvas_header.rb and 1 other location - About 40 mins to fix
lib/ui_bibz/ui/core/windows/components/modal_header.rb on lines 33..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language