Sign upLogin

thrawn01/args

View on GitHub
Star

Showing 80 of 80 total issues

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        It("Should match +four", func() {
            parser := args.NewParser()
            parser.AddOption("+four").Count()
            opt, err := parser.Parse(&cmdLine)
            Expect(err).To(BeNil())
Severity: Major
Found in parser_test.go and 6 other locations - About 35 mins to fix
parser_test.go on lines 67..73
parser_test.go on lines 74..80
parser_test.go on lines 81..87
parser_test.go on lines 95..101
parser_test.go on lines 371..377
parser_test.go on lines 416..422

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        It("Should match --one", func() {
            parser := args.NewParser()
            parser.AddOption("--one").Count()
            opt, err := parser.Parse(&cmdLine)
            Expect(err).To(BeNil())
Severity: Major
Found in parser_test.go and 6 other locations - About 35 mins to fix
parser_test.go on lines 74..80
parser_test.go on lines 81..87
parser_test.go on lines 88..94
parser_test.go on lines 95..101
parser_test.go on lines 371..377
parser_test.go on lines 416..422

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        It("Should match ++three", func() {
            parser := args.NewParser()
            parser.AddOption("++three").Count()
            opt, err := parser.Parse(&cmdLine)
            Expect(err).To(BeNil())
Severity: Major
Found in parser_test.go and 6 other locations - About 35 mins to fix
parser_test.go on lines 67..73
parser_test.go on lines 74..80
parser_test.go on lines 88..94
parser_test.go on lines 95..101
parser_test.go on lines 371..377
parser_test.go on lines 416..422

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        It("Should match first argument 'one'", func() {
            parser := args.NewParser()
            parser.AddArgument("first").IsString()
            opt, err := parser.Parse(&cmdLine)
            Expect(err).To(BeNil())
Severity: Major
Found in parser_test.go and 6 other locations - About 35 mins to fix
parser_test.go on lines 67..73
parser_test.go on lines 74..80
parser_test.go on lines 81..87
parser_test.go on lines 88..94
parser_test.go on lines 95..101
parser_test.go on lines 416..422

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        It("Should match --power-level", func() {
            parser := args.NewParser()
            parser.AddOption("--power-level").Count()
            opt, err := parser.Parse(&cmdLine)
            Expect(err).To(BeNil())
Severity: Major
Found in parser_test.go and 6 other locations - About 35 mins to fix
parser_test.go on lines 67..73
parser_test.go on lines 74..80
parser_test.go on lines 81..87
parser_test.go on lines 88..94
parser_test.go on lines 371..377
parser_test.go on lines 416..422

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func (self *Options) IsArg(key string) bool {
    if opt, ok := self.values[key]; ok {
        rule := opt.GetRule()
        if rule == nil {
            return false
Severity: Minor
Found in options.go and 2 other locations - About 30 mins to fix
options.go on lines 303..312
options.go on lines 327..336

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func (self *Options) IsEnv(key string) bool {
    if opt, ok := self.values[key]; ok {
        rule := opt.GetRule()
        if rule == nil {
            return false
Severity: Minor
Found in options.go and 2 other locations - About 30 mins to fix
options.go on lines 315..324
options.go on lines 327..336

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func (self *Options) IsDefault(key string) bool {
    if opt, ok := self.values[key]; ok {
        rule := opt.GetRule()
        if rule == nil {
            return false
Severity: Minor
Found in options.go and 2 other locations - About 30 mins to fix
options.go on lines 303..312
options.go on lines 315..324

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

TODO found
Open

    // TODO: Move this logic from here, This method should be all about getting the value
Severity: Minor
Found in rules.go by fixme

TODO found
Open

// TODO: Add these getters
Severity: Minor
Found in options.go by fixme

TODO found
Open

    // TODO: This should include the isRequired check
Severity: Minor
Found in parser.go by fixme

TODO found
Open

## TODO
Severity: Minor
Found in README.md by fixme

TODO found
Open

    // TODO: Should only return [OPTIONS] if there are too many options
Severity: Minor
Found in parser.go by fixme

TODO found
Open

    // TODO: This sort should happen when we validate rules
Severity: Minor
Found in rules.go by fixme

TODO found
Open

            // TODO: This should be user configurable
Severity: Minor
Found in ini.go by fixme

TODO found
Open

    // TODO: Wrap post parsing validation stuff into a method
Severity: Minor
Found in parser.go by fixme

TODO found
Open

    // TODO: Improve this once we have arguments
Severity: Minor
Found in parser.go by fixme

TODO found
Open

    // TODO: to display on a single line
Severity: Minor
Found in parser.go by fixme

TODO found
Open

// TODO: Make this less horribad, and use more reflection to make the interface simpler
Severity: Minor
Found in rule_modifier.go by fixme

TODO found
Open

    // TODO: Move this logic from here, This method should be all about getting the value
Severity: Minor
Found in rules.go by fixme
Severity
Category
Status
Source
Language