Sign upLogin

thrawn01/args

View on GitHub
Star
options.go

Summary

Maintainability
B
5 hrs
Test Coverage

Options has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

type Options struct {
    log    StdLogger
    parser *ArgParser
    values map[string]Value
}
Severity: Minor
Found in options.go - About 4 hrs to fix

    TODO found
    Open

    // TODO: Add these getters
    Severity: Minor
    Found in options.go by fixme

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (self *Options) IsArg(key string) bool {
    if opt, ok := self.values[key]; ok {
        rule := opt.GetRule()
        if rule == nil {
            return false
    Severity: Minor
    Found in options.go and 2 other locations - About 30 mins to fix
    options.go on lines 303..312
    options.go on lines 327..336

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (self *Options) IsEnv(key string) bool {
    if opt, ok := self.values[key]; ok {
        rule := opt.GetRule()
        if rule == nil {
            return false
    Severity: Minor
    Found in options.go and 2 other locations - About 30 mins to fix
    options.go on lines 315..324
    options.go on lines 327..336

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    func (self *Options) IsDefault(key string) bool {
    if opt, ok := self.values[key]; ok {
        rule := opt.GetRule()
        if rule == nil {
            return false
    Severity: Minor
    Found in options.go and 2 other locations - About 30 mins to fix
    options.go on lines 303..312
    options.go on lines 315..324

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status