Sign upLogin

threefunkymonkeys/chist

View on GitHub
Star
context/provider_auth.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method call has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def call
      if @user
        return :provider_duplicated if @user.has_provider?(@provider)
        return :provider_added if @user.add_provider(@provider, @auth_info.uid)
      elsif @user = User.find(:"#{@provider}_user" => @auth_info.uid)
Severity: Minor
Found in context/provider_auth.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method call has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def call
      if @user
        return :provider_duplicated if @user.has_provider?(@provider)
        return :provider_added if @user.add_provider(@provider, @auth_info.uid)
      elsif @user = User.find(:"#{@provider}_user" => @auth_info.uid)
Severity: Minor
Found in context/provider_auth.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                return :user_created
    Severity: Major
    Found in context/provider_auth.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return :account_exists
      Severity: Major
      Found in context/provider_auth.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status