Sign upLogin

thumbor/thumbor

View on GitHub
Star
thumbor/utils.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function ensure_srgb has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def ensure_srgb(img, srgb_profile=None):
    """
    Ensures that an image either has no ICC profile (and so is implicitly
    sRGB) or has an sRGB color profile. If the image is sRGB, it is returned
    unchanged. If it has a CMYK or Gray color profile, this function will
Severity: Minor
Found in thumbor/utils.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return dst_im
Severity: Major
Found in thumbor/utils.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return None
    Severity: Major
    Found in thumbor/utils.py - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status