Sign upLogin

tidalf/plugin.audio.qobuz

View on GitHub
Star
resources/lib/qobuz/cache/base_cache.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function cached has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    def cached(self, f, *a, **ka):
        """Decorator
            All positional and named parameters are used to make the key
        """
        that = self
Severity: Minor
Found in resources/lib/qobuz/cache/base_cache.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return data
Severity: Major
Found in resources/lib/qobuz/cache/base_cache.py - About 30 mins to fix

    Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed.
    Open

        def cached(self, f, *a, **ka):
    Severity: Critical
    Found in resources/lib/qobuz/cache/base_cache.py by sonar-python

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @classmethod
    def check_key(cls, data, key, *a, **ka):
        if 'key' not in data:
            return False
        if data['key'] != key:
    Severity: Minor
    Found in resources/lib/qobuz/cache/base_cache.py and 1 other location - About 50 mins to fix
    resources/lib/qobuz/cache/base_cache.py on lines 100..106

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @classmethod
    def check_magic(cls, data, *a, **ka):
        if 'magic' not in data:
            return False
        if data['magic'] != __magic__:
    Severity: Minor
    Found in resources/lib/qobuz/cache/base_cache.py and 1 other location - About 50 mins to fix
    resources/lib/qobuz/cache/base_cache.py on lines 108..114

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status