Sign upLogin

tidalf/plugin.audio.qobuz

View on GitHub
Star
resources/lib/qobuz/extension/kooli/kooli/application.py

Summary

Maintainability
B
6 hrs
Test Coverage

Cyclomatic complexity is too high in function route_album. (7)
Open

@nocache
@application.route('/qobuz/<string:album_id>/', methods=HEADGET)
def route_album(album_id=None, track_id=None):
    response = api.get('/album/get', album_id=album_id)
    if response is None:
Severity: Minor
Found in resources/lib/qobuz/extension/kooli/kooli/application.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function route_nfo_album. (6)
Open

@nocache
@application.route('/qobuz/<string:album_id>/album.nfo', methods=HEADGET)
def route_nfo_album(album_id=None):
    response = api.get('/album/get', album_id=album_id)
    if response is None:
Severity: Minor
Found in resources/lib/qobuz/extension/kooli/kooli/application.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Avoid too many return statements within this function.
Open

    return render_template('%s.htm.j2' % search_type, **node.data)
Severity: Major
Found in resources/lib/qobuz/extension/kooli/kooli/application.py - About 30 mins to fix

    Function route_album has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def route_album(album_id=None, track_id=None):
    response = api.get('/album/get', album_id=album_id)
    if response is None:
        response = api.get('/track/get', track_id=track_id)
    if response is None:
    Severity: Minor
    Found in resources/lib/qobuz/extension/kooli/kooli/application.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Remove this commented out code.
    Open

        # return redirect(url, code=302)
    Severity: Major
    Found in resources/lib/qobuz/extension/kooli/kooli/application.py by sonar-python

    Programmers should not comment out code as it bloats programs and reduces readability.

    Unused code should be deleted and can be retrieved from source control history if required.

    See

    • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
    • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
    • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
    • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        if 'description' in response:
        response['description'] = converter.strip_html(
            response['description'], default='')
    Severity: Major
    Found in resources/lib/qobuz/extension/kooli/kooli/application.py and 3 other locations - About 55 mins to fix
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 148..150
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 169..171
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 172..174

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        if 'catchline' in response:
        response['catchline'] = converter.strip_html(
            response['catchline'], default='')
    Severity: Major
    Found in resources/lib/qobuz/extension/kooli/kooli/application.py and 3 other locations - About 55 mins to fix
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 145..147
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 169..171
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 172..174

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        if 'catchline' in response:
        response['catchline'] = converter.strip_html(
            response['catchline'], default='')
    Severity: Major
    Found in resources/lib/qobuz/extension/kooli/kooli/application.py and 3 other locations - About 55 mins to fix
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 145..147
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 148..150
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 169..171

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        if 'description' in response:
        response['description'] = converter.strip_html(
            response['description'], default='')
    Severity: Major
    Found in resources/lib/qobuz/extension/kooli/kooli/application.py and 3 other locations - About 55 mins to fix
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 145..147
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 148..150
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 172..174

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    @nocache
@application.route('/qobuz/<string:album_id>/disc.png', methods=HEADGET)
@application.route('/qobuz/<string:album_id>/folder.jpg', methods=HEADGET)
@application.route('/qobuz/<string:album_id>/thumb.jpg', methods=HEADGET)
    Severity: Minor
    Found in resources/lib/qobuz/extension/kooli/kooli/application.py and 1 other location - About 45 mins to fix
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 199..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    @nocache
@application.route('/qobuz/favorite/', methods=HEADGET)
@application.route('/qobuz/favorite/<string:search_type>/', methods=HEADGET)
@application.route('/qobuz/favorite/<string:search_type>/<string:nid>',
    Severity: Minor
    Found in resources/lib/qobuz/extension/kooli/kooli/application.py and 1 other location - About 45 mins to fix
    resources/lib/qobuz/extension/kooli/kooli/application.py on lines 121..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Blank line contains whitespace
    Open
    Severity: Minor
    Found in resources/lib/qobuz/extension/kooli/kooli/application.py by pep8

    Trailing whitespace is superfluous.

    The warning returned varies on whether the line itself is blank,
for easier filtering for those who want to indent their blank lines.

Okay: spam(1)\n#
W291: spam(1) \n#
W293: class Foo(object):\n    \n    bang = 12

    Blank line contains whitespace
    Open
    Severity: Minor
    Found in resources/lib/qobuz/extension/kooli/kooli/application.py by pep8

    Trailing whitespace is superfluous.

    The warning returned varies on whether the line itself is blank,
for easier filtering for those who want to indent their blank lines.

Okay: spam(1)\n#
W291: spam(1) \n#
W293: class Foo(object):\n    \n    bang = 12

    Line too long (117 > 79 characters)
    Open

        return Response(stream_with_context(req.iter_content(chunk_size=2048)), content_type=req.headers["content-type"])
    Severity: Minor
    Found in resources/lib/qobuz/extension/kooli/kooli/application.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (80 > 79 characters)
    Open

    @application.route('/qobuz/<string:album_id>/characterart.png', methods=HEADGET)
    Severity: Minor
    Found in resources/lib/qobuz/extension/kooli/kooli/application.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (85 > 79 characters)
    Open

    @application.route('/qobuz/<string:album_id>/<string:track_id>.mpc', methods=HEADGET)
    Severity: Minor
    Found in resources/lib/qobuz/extension/kooli/kooli/application.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    There are no issues that match your filters.

    Category
    Status