Sign upLogin

tidalf/plugin.audio.qobuz

View on GitHub
Star
resources/lib/qobuz/node/track/main.py

Summary

Maintainability
C
1 day
Test Coverage

Node_track has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class Node_track(INode):
    def __init__(self, parent=None, parameters=None, data=None):
        parameters = {} if parameters is None else parameters
        super(Node_track, self).__init__(parent=parent,
                                         parameters=parameters,
Severity: Minor
Found in resources/lib/qobuz/node/track/main.py - About 3 hrs to fix

    Cyclomatic complexity is too high in method get_image. (9)
    Open

        def get_image(self, size=None, img_type='front', default=None):
        if size is None:
            size = config.app.registry.get('image_default_size')
        if img_type == 'thumbnail':
            image = self.get_property('album/image/thumbnail', default=None)
    Severity: Minor
    Found in resources/lib/qobuz/node/track/main.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    File main.py has 262 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    '''
    qobuz.node.track.main
    ~~~~~~~~~~~~~~~~~~~~~

    :part_of: kodi-qobuz
    Severity: Minor
    Found in resources/lib/qobuz/node/track/main.py - About 2 hrs to fix

      Cyclomatic complexity is too high in method get_year. (6)
      Open

          def get_year(self):
        date = self.get_property('album/year')
        if date is not None:
            return date
        date = self.get_property('album/released_at', default=None)
      Severity: Minor
      Found in resources/lib/qobuz/node/track/main.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in method get_label. (6)
      Open

          def get_label(self, default=None):
        fmt = "%a - %t"
        fmt = fmt.replace("%a", self.get_artist()) if '%a' in fmt else fmt
        fmt = fmt.replace("%A",
                          self.get_album_artist()) if '%A' in fmt else fmt
      Severity: Minor
      Found in resources/lib/qobuz/node/track/main.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in method is_playable. (6)
      Open

          def is_playable(self):
        streamable = self.get_property('streamable', default=None)
        if streamable is False and not user.is_free_account():
            return False
        url = self.get_streaming_url()
      Severity: Minor
      Found in resources/lib/qobuz/node/track/main.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Function get_image has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_image(self, size=None, img_type='front', default=None):
        if size is None:
            size = config.app.registry.get('image_default_size')
        if img_type == 'thumbnail':
            image = self.get_property('album/image/thumbnail', default=None)
      Severity: Minor
      Found in resources/lib/qobuz/node/track/main.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

              return True
      Severity: Major
      Found in resources/lib/qobuz/node/track/main.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return default
        Severity: Major
        Found in resources/lib/qobuz/node/track/main.py - About 30 mins to fix

          Function get_year has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def get_year(self):
        date = self.get_property('album/year')
        if date is not None:
            return date
        date = self.get_property('album/released_at', default=None)
          Severity: Minor
          Found in resources/lib/qobuz/node/track/main.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Merge this if statement with the enclosing one.
          Open

                      if self.parent is not None and self.parent.nt & Flag.ALBUM:
          Severity: Major
          Found in resources/lib/qobuz/node/track/main.py by sonar-python

          Merging collapsible if statements increases the code's readability.

          Noncompliant Code Example

          if condition1:
    if condition2:
        # ...

          Compliant Solution

          if condition1 and condition2:
    # ...

          Merge this if statement with the enclosing one.
          Open

                      if self.parent.nt & Flag.ALBUM == Flag.ALBUM:
          Severity: Major
          Found in resources/lib/qobuz/node/track/main.py by sonar-python

          Merging collapsible if statements increases the code's readability.

          Noncompliant Code Example

          if condition1:
    if condition2:
        # ...

          Compliant Solution

          if condition1 and condition2:
    # ...

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def attach_context_menu(self, item, menu):
        attach_context_menu(self, item, menu)
        super(Node_track, self).attach_context_menu(item, menu)
          Severity: Minor
          Found in resources/lib/qobuz/node/track/main.py and 1 other location - About 30 mins to fix
          resources/lib/qobuz/node/playlist/main.py on lines 206..208

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status