Sign upLogin

tidalf/plugin.audio.qobuz

View on GitHub
Star
resources/lib/qobuz/util/properties.py

Summary

Maintainability
A
3 hrs
Test Coverage

Cyclomatic complexity is too high in function bool_converter. (7)
Open

def bool_converter(value):
    if value in [True, False]:
        return value
    if isinstance(value, basestring):
        if value.lower() in ['yes', 'true']:
Severity: Minor
Found in resources/lib/qobuz/util/properties.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function deep_get. (7)
Open

def deep_get(data, path, sep='/', to=identity_converter):
    parts = [p for p in path.split(sep) if p]
    if parts is None:
        return path, None
    root = data[parts.pop(0)]
Severity: Minor
Found in resources/lib/qobuz/util/properties.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function get_mapped. (7)
Open

def get_mapped(data, props, key, sep='/', default=None):
    if key not in props:
        raise KeyError('No mapped key {}'.format(key))
    prop = props.get(key)
    if 'alias' in prop:
Severity: Minor
Found in resources/lib/qobuz/util/properties.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function bool_converter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def bool_converter(value):
    if value in [True, False]:
        return value
    if isinstance(value, basestring):
        if value.lower() in ['yes', 'true']:
Severity: Minor
Found in resources/lib/qobuz/util/properties.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_mapped has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def get_mapped(data, props, key, sep='/', default=None):
    if key not in props:
        raise KeyError('No mapped key {}'.format(key))
    prop = props.get(key)
    if 'alias' in prop:
Severity: Minor
Found in resources/lib/qobuz/util/properties.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_mapped has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def get_mapped(data, props, key, sep='/', default=None):
Severity: Minor
Found in resources/lib/qobuz/util/properties.py - About 35 mins to fix

    Avoid too many return statements within this function.
    Open

        return False
    Severity: Major
    Found in resources/lib/qobuz/util/properties.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return True
      Severity: Major
      Found in resources/lib/qobuz/util/properties.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return True
        Severity: Major
        Found in resources/lib/qobuz/util/properties.py - About 30 mins to fix

          Indentation is not a multiple of 4
          Open

                     root = ""
          Severity: Minor
          Found in resources/lib/qobuz/util/properties.py by pep8

          Use indent_size (PEP8 says 4) spaces per indentation level.

          For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

          Indentation is not a multiple of 4
          Open

                     root = root[part]
          Severity: Minor
          Found in resources/lib/qobuz/util/properties.py by pep8

          Use indent_size (PEP8 says 4) spaces per indentation level.

          For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

          Do not use bare 'except'
          Open

                  except:
          Severity: Minor
          Found in resources/lib/qobuz/util/properties.py by pep8

          When catching exceptions, mention specific exceptions when possible.

          Okay: except Exception:
Okay: except BaseException:
E722: except:

          There are no issues that match your filters.

          Category
          Status