Sign upLogin

timegridio/concierge

View on GitHub
Star
src/Concierge.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method takeReservation has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function takeReservation(array $request)
    {
        $issuer = $request['issuer'];
        $service = $request['service'];
        $contact = $request['contact'];
Severity: Minor
Found in src/Concierge.php - About 1 hr to fix

    Method generateAppointment has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $issuerId,
        $businessId,
        $contactId,
        $serviceId,
        Carbon $startAt,
    Severity: Major
    Found in src/Concierge.php - About 1 hr to fix

      Avoid using static access to class '\Carbon\Carbon' in method 'makeDateTime'.
      Open

              return Carbon::parse("{$date} {$time} {$timezone}");
      Severity: Minor
      Found in src/Concierge.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      TODO found
      Open

                  // TODO: Log failure feedback message / raise exception
      Severity: Minor
      Found in src/Concierge.php by fixme

      There are no issues that match your filters.

      Category
      Status