Sign upLogin

timegridio/concierge

View on GitHub
Star
src/Models/Humanresource.php

Summary

Maintainability
A
0 mins
Test Coverage

TODO found
Open

     * TODO: Check slug setting can be moved to a more proper place.
Severity: Minor
Found in src/Models/Humanresource.php by fixme

The parameter $calendar_link is not named in camelCase.
Open

    public function setCalendarLinkAttribute($calendar_link)
    {
        return $this->attributes['calendar_link'] = trim($calendar_link) ?: null;
    }
Severity: Minor
Found in src/Models/Humanresource.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The variable $calendar_link is not named in camelCase.
Open

    public function setCalendarLinkAttribute($calendar_link)
    {
        return $this->attributes['calendar_link'] = trim($calendar_link) ?: null;
    }
Severity: Minor
Found in src/Models/Humanresource.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status