src/Presenters/AppointmentPresenter.php
The class AppointmentPresenter has 15 public methods. Consider refactoring AppointmentPresenter to keep number of public methods under 10. Open
Open
class AppointmentPresenter extends BasePresenter
{
protected $timezone = null;
public function __construct(Appointment $resource)- Read upRead up
- Exclude checks
TooManyPublicMethods
Since: 0.1
A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.
By default it ignores methods starting with 'get' or 'set'.
Example
Source https://phpmd.org/rules/codesize.html#toomanypublicmethods
The method setTimezone has a boolean flag argument $timezone, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function setTimezone($timezone = false)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}