Sign upLogin

timegridio/concierge

View on GitHub
Star
src/Timetable/Timetable.php

Summary

Maintainability
A
25 mins
Test Coverage

The class Timetable has 12 public methods. Consider refactoring Timetable to keep number of public methods under 10.
Open

class Timetable
{
    /**
     * Timetable matrix.
     *
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Function init has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function init()
    {
        $this->timetable = [];

        $dimensions['service'] = $this->inflateServices();
Severity: Minor
Found in src/Timetable/Timetable.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using undefined variables such as '$dimensions' which will lead to PHP notices.
Open

            foreach ($dimensions['date'] as $date) {
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$dimensions' which will lead to PHP notices.
Open

        foreach ($dimensions['service'] as $service) {
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$dimensions' which will lead to PHP notices.
Open

        $dimensions['service'] = $this->inflateServices();
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$dates' which will lead to PHP notices.
Open

        return $dates;
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$dimensions' which will lead to PHP notices.
Open

                foreach ($dimensions['time'] as $time) {
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$dimensions' which will lead to PHP notices.
Open

        $dimensions['time'] = $this->inflateTimes();
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$dates' which will lead to PHP notices.
Open

            $dates[$date] = $date;
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$dimensions' which will lead to PHP notices.
Open

        $dimensions['date'] = $this->inflateDates();
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using static access to class '\Illuminate\Support\Arr' in method 'array_set'.
Open

        return Arr::set($array, $key, $value);
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Arr' in method 'array_get'.
Open

        return Arr::get($array, $key, $default);
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method array_substitute is not named in camelCase.
Open

    private function array_substitute(&$array1, $array2)
    {
        foreach ($array1 as $key => $value) {
            $array1[$key] = $array2[$value];
        }
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method array_get is not named in camelCase.
Open

    private function array_get($array, $key, $default = null)
    {
        return Arr::get($array, $key, $default);
    }
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method array_set is not named in camelCase.
Open

    private function array_set(&$array, $key, $value)
    {
        return Arr::set($array, $key, $value);
    }
Severity: Minor
Found in src/Timetable/Timetable.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status