Sign upLogin

timegridio/concierge

View on GitHub
Star
src/Vacancy/VacancyManager.php

Summary

Maintainability
A
1 hr
Test Coverage

Method publish has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function publish($date, Carbon $startAt, Carbon $finishAt, $serviceId, $capacity = 1)
Severity: Minor
Found in src/Vacancy/VacancyManager.php - About 35 mins to fix

    Function processServiceStatements has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function processServiceStatements($business, $date, $services)
    {
        $changed = false;
        foreach ($services as $serviceSlug => $statements) {
            $service = $business->services()->where('slug', $serviceSlug)->get()->first();
    Severity: Minor
    Found in src/Vacancy/VacancyManager.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid unused local variables such as '$hash'.
    Open

            foreach ($array as $hash => $item) {
    Severity: Minor
    Found in src/Vacancy/VacancyManager.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    TODO found
    Open

                    //  TODO: Still, a user-level WARNING should be raised with no fatal error
    Severity: Minor
    Found in src/Vacancy/VacancyManager.php by fixme

    Avoid using static access to class '\Timegridio\Concierge\Models\Vacancy' in method 'publish'.
    Open

            return Vacancy::updateOrCreate($vacancyKeys, $vacancyValues);
    Severity: Minor
    Found in src/Vacancy/VacancyManager.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Timegridio\Concierge\Models\Vacancy' in method 'publishVacancy'.
    Open

            $vacancy = Vacancy::create($vacancyValues);
    Severity: Minor
    Found in src/Vacancy/VacancyManager.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Carbon\Carbon' in method 'processServiceStatements'.
    Open

                $vacancy = $business->vacancies()->forDate(Carbon::parse($date))->forService($service->id);
    Severity: Minor
    Found in src/Vacancy/VacancyManager.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method publishVacancy uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            {
            $vacancyValues['capacity'] = intval($statement['capacity']);
        }
    Severity: Minor
    Found in src/Vacancy/VacancyManager.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    There are no issues that match your filters.

    Category
    Status