Sign upLogin

timegridio/timegrid

View on GitHub
Star
app/Listeners/UserEventListener.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid unused parameters such as '$logout'.
Open

    public function onUserLogout(Logout $logout)
Severity: Minor
Found in app/Listeners/UserEventListener.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Carbon\Carbon' in method 'touchAudit'.
Open

        $user->last_login_at = Carbon::now();
Severity: Minor
Found in app/Listeners/UserEventListener.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid assigning values to variables in if clauses and the like (line '59', column '13').
Open

    protected function loadSessionPreferences(User $user)
    {
        logger()->info("Loading user preferences");
        if ($timezone = $user->pref('timezone')) {
            session()->set('timezone', $timezone);
Severity: Minor
Found in app/Listeners/UserEventListener.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

There are no issues that match your filters.

Category
Status