Sign upLogin

timjb/diagrams-rubiks-cube

View on GitHub
Star
src/Diagrams/RubiksCube/Model.hs

Summary

Maintainability
Test Coverage

Unused LANGUAGE pragma
Open

{-# LANGUAGE KindSignatures #-}
Severity: Minor
Found in src/Diagrams/RubiksCube/Model.hs by hlint

Found

{-# LANGUAGE KindSignatures #-}

Perhaps

Applying this change:

  • Extension KindSignatures is implied by TypeFamilies

Redundant bracket
Open

    (\upSide' upRows' -> c & upSide .~ upSide' & upRows .~ upRows')
       <$> (traverse f (c ^. upSide))
       <*> (traverse (traverse f) (c ^. upRows))
Severity: Minor
Found in src/Diagrams/RubiksCube/Model.hs by hlint

Found

(\ upSide' upRows' -> c & upSide .~ upSide' & upRows .~ upRows')
  <$> (traverse f (c ^. upSide))
  <*> (traverse (traverse f) (c ^. upRows))

Perhaps

(\ upSide' upRows' -> c & upSide .~ upSide' & upRows .~ upRows')
  <$> (traverse f (c ^. upSide))
  <*> traverse (traverse f) (c ^. upRows)

Redundant bracket
Open

    (\upSide' upRows' -> c & upSide .~ upSide' & upRows .~ upRows')
       <$> (traverse f (c ^. upSide))
Severity: Minor
Found in src/Diagrams/RubiksCube/Model.hs by hlint

Found

(\ upSide' upRows' -> c & upSide .~ upSide' & upRows .~ upRows')
  <$> (traverse f (c ^. upSide))

Perhaps

(\ upSide' upRows' -> c & upSide .~ upSide' & upRows .~ upRows')
  <$> traverse f (c ^. upSide)

Redundant bracket
Open

    (\downSide' downRows' -> c & downSide .~ downSide' & downRows .~ downRows')
       <$> (traverse f (c ^. downSide))
Severity: Minor
Found in src/Diagrams/RubiksCube/Model.hs by hlint

Found

(\ downSide' downRows' ->
   c & downSide .~ downSide' & downRows .~ downRows')
  <$> (traverse f (c ^. downSide))

Perhaps

(\ downSide' downRows' ->
   c & downSide .~ downSide' & downRows .~ downRows')
  <$> traverse f (c ^. downSide)

Redundant bracket
Open

    (\downSide' downRows' -> c & downSide .~ downSide' & downRows .~ downRows')
       <$> (traverse f (c ^. downSide))
       <*> (traverse (traverse f) (c ^. downRows))
Severity: Minor
Found in src/Diagrams/RubiksCube/Model.hs by hlint

Found

(\ downSide' downRows' ->
   c & downSide .~ downSide' & downRows .~ downRows')
  <$> (traverse f (c ^. downSide))
  <*> (traverse (traverse f) (c ^. downRows))

Perhaps

(\ downSide' downRows' ->
   c & downSide .~ downSide' & downRows .~ downRows')
  <$> (traverse f (c ^. downSide))
  <*> traverse (traverse f) (c ^. downRows)

Use foldr
Open

doMoves [] = iso id id
doMoves (m:ms) = move m . doMoves ms
Severity: Minor
Found in src/Diagrams/RubiksCube/Model.hs by hlint

Found

doMoves [] = iso id id
doMoves (m : ms) = move m . doMoves ms

Perhaps

doMoves ms = foldr ((.) . move) (iso id id) ms

Avoid lambda
Open

  _3 f (Vec3 a b c) = (\c' -> Vec3 a b c') <$> f c
Severity: Minor
Found in src/Diagrams/RubiksCube/Model.hs by hlint

Found

\ c' -> Vec3 a b c'

Perhaps

Vec3 a b

There are no issues that match your filters.

Category
Status