Sign upLogin

timothyandrew/blink

View on GitHub
Star

Showing 11 of 11 total issues

Function editorConfig has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

CKEDITOR.editorConfig = function( config )
{
  // Define changes to default configuration here. For example:
  config.defaultLanguage = 'en';
  config.language = 'en';
Severity: Major
Found in app/assets/javascripts/ckeditor/config.js - About 2 hrs to fix

    Function editorConfig has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    CKEDITOR.editorConfig = function( config )
{
  // Define changes to default configuration here. For example:
  config.defaultLanguage = 'en';
  config.language = 'en';
    Severity: Minor
    Found in app/assets/javascripts/ckeditor/config.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method generate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def generate
      draw_student_name

      @copy_count.times do |i|
        render_title
    Severity: Minor
    Found in app/services/form_generator/service.rb - About 1 hr to fix

      Method generate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def generate
      draw_student_name

      @copy_count.times do |i|
        render_title
      Severity: Minor
      Found in app/services/form_generator/service.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_attributes_with_children has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def update_attributes_with_children(attributes, children_attributes)
    children_attributes ||= {}
    children_to_delete = self.items.where.not(id: children_attributes.map { |_, child| child[:id] })
    transaction do
      children_to_delete.destroy_all
      Severity: Minor
      Found in app/models/lesson_plan.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_changes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def update_changes
    model.audited_changes.map do |column, change|
      old, new = change
      if new == true || new == false
        "<div class='changed-from-literal'>It was marked #{'not' if new == false} #{column}</div>"
      Severity: Minor
      Found in app/decorators/student_audit_decorator.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method quick_create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def quick_create
    @parent = @student.goals.find_by_id(params[:parent_id]) if params[:parent_id]
    parsed_goals = GoalParsing::Service.parse(params[:goals].strip)
    if parsed_goals && Goal.save_many_with_category(parsed_goals, @student, @parent)
      flash[:notice] = "Goals were created."
      Severity: Minor
      Found in app/controllers/goals_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def update
    @student = current_user.students.find(params[:id])
    if @student.update_attributes(student_params)
      flash[:notice] = "Student was updated"
      redirect_to students_path
      Severity: Minor
      Found in app/controllers/students_controller.rb and 1 other location - About 25 mins to fix
      app/controllers/worksheets_controller.rb on lines 25..33

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def update
    @worksheet = current_user.worksheets.find(params[:id])
    if @worksheet.update_attributes(worksheet_params)
      flash[:notice] = "Worksheet was edited"
      redirect_to worksheets_path
      Severity: Minor
      Found in app/controllers/worksheets_controller.rb and 1 other location - About 25 mins to fix
      app/controllers/students_controller.rb on lines 31..39

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def create
    @worksheet = current_user.worksheets.new(worksheet_params)
    if @worksheet.save
      flash[:notice] = "Worksheet was created"
      redirect_to worksheets_path
      Severity: Minor
      Found in app/controllers/worksheets_controller.rb and 1 other location - About 20 mins to fix
      app/controllers/students_controller.rb on lines 20..28

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def create
    @student = current_user.students.new(student_params)
    if @student.save
      flash[:notice] = "Student was created"
      redirect_to students_path
      Severity: Minor
      Found in app/controllers/students_controller.rb and 1 other location - About 20 mins to fix
      app/controllers/worksheets_controller.rb on lines 14..22

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language