Sign upLogin

tjs-w/go-proto-stomp

View on GitHub
Star
pkg/stomp/broker.go

Summary

Maintainability
A
3 hrs
Test Coverage
C
78%

Method Session.stateMachine has 57 lines of code (exceeds 50 allowed). Consider refactoring.
Invalid

func (sess *Session) stateMachine(frame *Frame) error {
    switch frame.command {
    case CmdConnect, CmdStomp:
        if err := sess.handleConnect(frame); err != nil {
            return err
Severity: Minor
Found in pkg/stomp/broker.go - About 1 hr to fix

    Method Session.stateMachine has 13 return statements (exceeds 4 allowed).
    Invalid

    func (sess *Session) stateMachine(frame *Frame) error {
    switch frame.command {
    case CmdConnect, CmdStomp:
        if err := sess.handleConnect(frame); err != nil {
            return err
    Severity: Major
    Found in pkg/stomp/broker.go - About 1 hr to fix

      Method Session.stateMachine has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Wontfix

      func (sess *Session) stateMachine(frame *Frame) error {
    switch frame.command {
    case CmdConnect, CmdStomp:
        if err := sess.handleConnect(frame); err != nil {
            return err
      Severity: Minor
      Found in pkg/stomp/broker.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Session.sendMessage has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Invalid

      func (sess *Session) sendMessage(dest, subsID string, ackNum uint32, txID string, headers map[Header]string,
    body []byte,
      Severity: Minor
      Found in pkg/stomp/broker.go - About 35 mins to fix

        Method Session.send has 5 return statements (exceeds 4 allowed).
        Invalid

        func (sess *Session) send(cmd Command, headers map[Header]string, body []byte) error {
    f := NewFrame(cmd, headers, body)

    // Make this check optional later
    if err := f.Validate(ServerFrame); err != nil {
        Severity: Major
        Found in pkg/stomp/broker.go - About 35 mins to fix

          Method Session.handleConnect has 5 return statements (exceeds 4 allowed).
          Invalid

          func (sess *Session) handleConnect(f *Frame) error {
    // Authentication
    if sess.loginFunc != nil {
        login, passcode := f.getHeader(HdrKeyLogin), f.getHeader(HdrKeyPassCode)
        if err := sess.loginFunc(login, passcode); err != nil {
          Severity: Major
          Found in pkg/stomp/broker.go - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (sess *Session) negotiateHeartbeats(hbVal string) error {
    clientSendInterval, clientRecvInterval, err := parseHbVal(hbVal)
    if err != nil {
        return err
    }
            Severity: Major
            Found in pkg/stomp/broker.go and 1 other location - About 3 hrs to fix
            pkg/stomp/client.go on lines 260..292

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 283.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status