Sign upLogin

tkqubo/conditional-decorator

View on GitHub
Star
src/utils.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export function isClassDecorator(decorator: Function, args: IArguments): decorator is ClassDecorator {
  'use strict';
  return getDecoratorTypeFromArguments(args) === DecoratorType.Class;
}
Severity: Major
Found in src/utils.ts and 2 other locations - About 1 hr to fix
src/utils.ts on lines 71..74
src/utils.ts on lines 82..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export function isParameterDecorator(decorator: Function, args: IArguments): decorator is ParameterDecorator {
  'use strict';
  return getDecoratorTypeFromArguments(args) === DecoratorType.Parameter;
}
Severity: Major
Found in src/utils.ts and 2 other locations - About 1 hr to fix
src/utils.ts on lines 60..63
src/utils.ts on lines 82..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export function isPropertyDecorator(decorator: Function, args: IArguments): decorator is PropertyDecorator {
  'use strict';
  return getDecoratorTypeFromArguments(args) === DecoratorType.Property;
}
Severity: Major
Found in src/utils.ts and 2 other locations - About 1 hr to fix
src/utils.ts on lines 60..63
src/utils.ts on lines 71..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

interface name must start with a capitalized I
Open

export interface MethodDecorator {
Severity: Minor
Found in src/utils.ts by tslint

Rule: interface-name

Requires interface names to begin with a capital 'I'

Rationale

Makes it easy to differentiate interfaces from regular classes at a glance.

Notes
  • TypeScript Only

Config

One of the following two options must be provided:

  • "always-prefix" requires interface names to start with an "I"
  • "never-prefix" requires interface names to not have an "I" prefix
Examples
"interface-name": true,always-prefix
"interface-name": true,never-prefix
Schema
{
  "type": "string",
  "enum": [
    "always-prefix",
    "never-prefix"
  ]
}

For more information see this page.

interface name must start with a capitalized I
Open

export interface ClassDecorator {
Severity: Minor
Found in src/utils.ts by tslint

Rule: interface-name

Requires interface names to begin with a capital 'I'

Rationale

Makes it easy to differentiate interfaces from regular classes at a glance.

Notes
  • TypeScript Only

Config

One of the following two options must be provided:

  • "always-prefix" requires interface names to start with an "I"
  • "never-prefix" requires interface names to not have an "I" prefix
Examples
"interface-name": true,always-prefix
"interface-name": true,never-prefix
Schema
{
  "type": "string",
  "enum": [
    "always-prefix",
    "never-prefix"
  ]
}

For more information see this page.

interface name must start with a capitalized I
Open

export interface ParameterDecorator {
Severity: Minor
Found in src/utils.ts by tslint

Rule: interface-name

Requires interface names to begin with a capital 'I'

Rationale

Makes it easy to differentiate interfaces from regular classes at a glance.

Notes
  • TypeScript Only

Config

One of the following two options must be provided:

  • "always-prefix" requires interface names to start with an "I"
  • "never-prefix" requires interface names to not have an "I" prefix
Examples
"interface-name": true,always-prefix
"interface-name": true,never-prefix
Schema
{
  "type": "string",
  "enum": [
    "always-prefix",
    "never-prefix"
  ]
}

For more information see this page.

interface name must start with a capitalized I
Open

export interface PropertyDecorator {
Severity: Minor
Found in src/utils.ts by tslint

Rule: interface-name

Requires interface names to begin with a capital 'I'

Rationale

Makes it easy to differentiate interfaces from regular classes at a glance.

Notes
  • TypeScript Only

Config

One of the following two options must be provided:

  • "always-prefix" requires interface names to start with an "I"
  • "never-prefix" requires interface names to not have an "I" prefix
Examples
"interface-name": true,always-prefix
"interface-name": true,never-prefix
Schema
{
  "type": "string",
  "enum": [
    "always-prefix",
    "never-prefix"
  ]
}

For more information see this page.

There are no issues that match your filters.

Category
Status