Sign upLogin

tlab-jp/rakudax

View on GitHub
Star
lib/rakudax/tasks/generate.rb

Summary

Maintainability
F
3 days
Test Coverage

Method generate has a Cognitive Complexity of 106 (exceeds 5 allowed). Consider refactoring.
Open

    def self.generate
      FileUtils.rm_rf Rakudax::Base.im_path
      FileUtils.mkdir_p Rakudax::Base.im_path

      puts "[start generate]=============#{Time.now}"
Severity: Minor
Found in lib/rakudax/tasks/generate.rb - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has too many lines. [145/30]
Open

    def self.generate
      FileUtils.rm_rf Rakudax::Base.im_path
      FileUtils.mkdir_p Rakudax::Base.im_path

      puts "[start generate]=============#{Time.now}"
Severity: Minor
Found in lib/rakudax/tasks/generate.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for generate is too high. [44/6]
Open

    def self.generate
      FileUtils.rm_rf Rakudax::Base.im_path
      FileUtils.mkdir_p Rakudax::Base.im_path

      puts "[start generate]=============#{Time.now}"
Severity: Minor
Found in lib/rakudax/tasks/generate.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method generate has 145 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.generate
      FileUtils.rm_rf Rakudax::Base.im_path
      FileUtils.mkdir_p Rakudax::Base.im_path

      puts "[start generate]=============#{Time.now}"
Severity: Major
Found in lib/rakudax/tasks/generate.rb - About 5 hrs to fix

    Consider simplifying this complex logical expression.
    Open

                      if v.nil? || v.blank? || k == "creater" || k == "updater" || (model.keep_encodes || []).include?(k)
                    next
                  elsif v.is_a?(String)
                    value[k] = NKF.nkf opt, v
                  else
    Severity: Major
    Found in lib/rakudax/tasks/generate.rb - About 40 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              case Rakudax::Base.output_type
        when "yaml"
          File.open(Rakudax::Base.im_path.join(model_name), 'w') do | file |
            file << YAML.dump(Rakudax::Base.models[model_name])
          end
      Severity: Major
      Found in lib/rakudax/tasks/generate.rb and 1 other location - About 1 hr to fix
      lib/rakudax/tasks/generate.rb on lines 127..138

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  case Rakudax::Base.output_type
            when "yaml"
              File.open(Rakudax::Base.im_path.join(model_name), 'w') do | file |
                file << YAML.dump(Rakudax::Base.models[model_name])
              end
      Severity: Major
      Found in lib/rakudax/tasks/generate.rb and 1 other location - About 1 hr to fix
      lib/rakudax/tasks/generate.rb on lines 147..158

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

              (model.associations || []).each do |asc| 
          next unless asc.method
          next unless asc.scope
          gen_code += "#{asc.method} :#{asc.scope}#{", #{asc.options}" unless asc.options.nil?}
          "
      Severity: Major
      Found in lib/rakudax/tasks/generate.rb and 6 other locations - About 40 mins to fix
      lib/rakudax/tasks/migrate.rb on lines 21..26
      lib/rakudax/tasks/migrate.rb on lines 58..63
      lib/rakudax/tasks/migrate.rb on lines 65..70
      lib/rakudax/tasks/submit.rb on lines 18..23
      lib/rakudax/tasks/submit.rb on lines 25..30
      lib/rakudax/tasks/verify.rb on lines 23..28

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      The use of eval is a serious security risk.
      Open

              eval gen_code
      Severity: Minor
      Found in lib/rakudax/tasks/generate.rb by rubocop

      This cop checks for the use of Kernel#eval and Binding#eval.

      Example:

      # bad

eval(something)
binding.eval(something)

      There are no issues that match your filters.

      Category
      Status