Sign upLogin

tlab-jp/rakudax

View on GitHub
Star
lib/rakudax/tasks/submit.rb

Summary

Maintainability
D
2 days
Test Coverage

Method submit has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
Open

    def self.submit
      unless Dir.exists?(Rakudax::Base.im_path)
        puts "error: Intermediate directory not found."
        puts "Intermediate directory path: #{Rakudax::Base.im_path}"
        exit 2
Severity: Minor
Found in lib/rakudax/tasks/submit.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has too many lines. [95/30]
Open

    def self.submit
      unless Dir.exists?(Rakudax::Base.im_path)
        puts "error: Intermediate directory not found."
        puts "Intermediate directory path: #{Rakudax::Base.im_path}"
        exit 2
Severity: Minor
Found in lib/rakudax/tasks/submit.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for submit is too high. [25/6]
Open

    def self.submit
      unless Dir.exists?(Rakudax::Base.im_path)
        puts "error: Intermediate directory not found."
        puts "Intermediate directory path: #{Rakudax::Base.im_path}"
        exit 2
Severity: Minor
Found in lib/rakudax/tasks/submit.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method submit has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.submit
      unless Dir.exists?(Rakudax::Base.im_path)
        puts "error: Intermediate directory not found."
        puts "Intermediate directory path: #{Rakudax::Base.im_path}"
        exit 2
Severity: Major
Found in lib/rakudax/tasks/submit.rb - About 3 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if Rakudax::Settings.force_reset
          print "Delete All #{classname}s ... "
          tablename = model.table || classname.tableize
          ActiveRecord::Base.establish_connection Rakudax::Base.dbconfig[model.db]
          case Rakudax::Base.dbconfig[model.db]["adapter"]
    Severity: Major
    Found in lib/rakudax/tasks/submit.rb and 1 other location - About 2 hrs to fix
    lib/rakudax/tasks/migrate.rb on lines 104..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

            (model.associations || []).each do |asc|
          next unless asc.method
          next unless asc.scope
          gen_code += "#{asc.method} :#{asc.scope}#{", #{asc.options}" unless asc.options.nil?}
          "
    Severity: Major
    Found in lib/rakudax/tasks/submit.rb and 6 other locations - About 40 mins to fix
    lib/rakudax/tasks/generate.rb on lines 23..28
    lib/rakudax/tasks/migrate.rb on lines 21..26
    lib/rakudax/tasks/migrate.rb on lines 58..63
    lib/rakudax/tasks/migrate.rb on lines 65..70
    lib/rakudax/tasks/submit.rb on lines 25..30
    lib/rakudax/tasks/verify.rb on lines 23..28

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

            (model.attrs || []).each do |attr| 
          next unless attr.method
          next unless attr.scope
          gen_code += "#{attr.method} :#{attr.scope}#{", #{attr.options}" unless attr.options.nil?}
          "
    Severity: Major
    Found in lib/rakudax/tasks/submit.rb and 6 other locations - About 40 mins to fix
    lib/rakudax/tasks/generate.rb on lines 23..28
    lib/rakudax/tasks/migrate.rb on lines 21..26
    lib/rakudax/tasks/migrate.rb on lines 58..63
    lib/rakudax/tasks/migrate.rb on lines 65..70
    lib/rakudax/tasks/submit.rb on lines 18..23
    lib/rakudax/tasks/verify.rb on lines 23..28

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File.exists? is deprecated in favor of File.exist?.
    Open

            unless File.exists?(data_path)
    Severity: Minor
    Found in lib/rakudax/tasks/submit.rb by rubocop

    This cop checks for uses of the deprecated class method usages.

    Example:

    # bad

File.exists?(some_path)

    Example:

    # good

File.exist?(some_path)

    The use of eval is a serious security risk.
    Open

            eval gen_code
    Severity: Minor
    Found in lib/rakudax/tasks/submit.rb by rubocop

    This cop checks for the use of Kernel#eval and Binding#eval.

    Example:

    # bad

eval(something)
binding.eval(something)

    Useless assignment to variable - value.
    Open

            value = nil
    Severity: Minor
    Found in lib/rakudax/tasks/submit.rb by rubocop

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad

def some_method
  some_var = 1
  do_something
end

    Example:

    # good

def some_method
  some_var = 1
  do_something(some_var)
end

    Dir.exists? is deprecated in favor of Dir.exist?.
    Open

          unless Dir.exists?(Rakudax::Base.im_path)
    Severity: Minor
    Found in lib/rakudax/tasks/submit.rb by rubocop

    This cop checks for uses of the deprecated class method usages.

    Example:

    # bad

File.exists?(some_path)

    Example:

    # good

File.exist?(some_path)

    Redundant use of Object#to_s in interpolation.
    Open

            print "Submit #{const_get(classname).to_s}#{"s" if value.count > 1} ..."
    Severity: Minor
    Found in lib/rakudax/tasks/submit.rb by rubocop

    This cop checks for string conversion in string interpolation, which is redundant.

    Example:

    # bad

"result is #{something.to_s}"

    Example:

    # good

"result is #{something}"

    There are no issues that match your filters.

    Category
    Status