tlsfuzzer/tlsfuzzer

View on GitHub
tlsfuzzer/extract.py

Summary

Maintainability
F
1 wk
Test Coverage
A
96%

File extract.py has 1395 lines of code (exceeds 500 allowed). Consider refactoring.
Open

# Author: Jan Koscielniak, (c) 2020
# Released under Gnu GPL v2.0, see LICENSE file for details

"""Extraction and analysis of timing information from a packet capture."""

Severity: Major
Found in tlsfuzzer/extract.py - About 2 days to fix

    Cyclomatic complexity is too high in function main. (50)
    Open

    def main():
        """Process arguments and start extraction."""
        logfile = None
        capture = None
        output = None
    Severity: Minor
    Found in tlsfuzzer/extract.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function main has a Cognitive Complexity of 56 (exceeds 10 allowed). Consider refactoring.
    Open

    def main():
        """Process arguments and start extraction."""
        logfile = None
        capture = None
        output = None
    Severity: Minor
    Found in tlsfuzzer/extract.py - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _parse_pcap has a Cognitive Complexity of 51 (exceeds 10 allowed). Consider refactoring.
    Open

        def _parse_pcap(self):
            """Process capture file."""
            with open(self.capture, 'rb') as pcap:
                progress = None
                try:
    Severity: Minor
    Found in tlsfuzzer/extract.py - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity is too high in method _parse_pcap. (42)
    Open

        def _parse_pcap(self):
            """Process capture file."""
            with open(self.capture, 'rb') as pcap:
                progress = None
                try:
    Severity: Minor
    Found in tlsfuzzer/extract.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Consider simplifying this complex logical expression.
    Open

                        if (tcp_pkt.flags & dpkt.tcp.TH_SYN and
                                tcp_pkt.dport == self.port and
                                ip_pkt.dst == self.ip_address):
                            # a SYN packet was found - new connection
                            # (if a retransmission it won't be counted as at least
    Severity: Critical
    Found in tlsfuzzer/extract.py - About 6 hrs to fix

      Extract has 37 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Extract:
          """Extract timing information from packet capture."""
      
          def __init__(self, log=None, capture=None, output=None, ip_address=None,
                       port=None, raw_times=None, col_name=None,
      Severity: Minor
      Found in tlsfuzzer/extract.py - About 4 hrs to fix

        Function _write_pkts has a Cognitive Complexity of 33 (exceeds 10 allowed). Consider refactoring.
        Open

            def _write_pkts(self):
                for _, _, _, clnt_msgs, clnt_msgs_acks, srv_msgs, srv_msgs_acks, _, _, _ in self.pckt_times:
                    if len(clnt_msgs) != len(clnt_msgs_acks): # pragma: no cover
                        # no coverage; assert
                        print(clnt_msgs)
        Severity: Minor
        Found in tlsfuzzer/extract.py - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function process_measurements_and_create_csv_file has a Cognitive Complexity of 33 (exceeds 10 allowed). Consider refactoring.
        Open

            def process_measurements_and_create_csv_file(
                    self, values_iter, comparing_value
                    ):
                """
                Processing all the nonces and associated time measurements from the
        Severity: Minor
        Found in tlsfuzzer/extract.py - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function add_timing has a Cognitive Complexity of 29 (exceeds 10 allowed). Consider refactoring.
        Open

            def add_timing(self):
                """Associate the timing information with its class"""
                if self.client_message and self.server_message:
                    if self.warm_up_messages_left == 0:
                        class_index = next(self.class_generator)
        Severity: Minor
        Found in tlsfuzzer/extract.py - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Cyclomatic complexity is too high in method process_rsa_keys. (19)
        Open

            def process_rsa_keys(self):
                # list of values for the Hamming weight of d, p, q, dP, dQ, qInv
                values = []
                times = []
                max_len = 20
        Severity: Minor
        Found in tlsfuzzer/extract.py by radon

        Cyclomatic Complexity

        Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

        Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

        Construct Effect on CC Reasoning
        if +1 An if statement is a single decision.
        elif +1 The elif statement adds another decision.
        else +0 The else statement does not cause a new decision. The decision is at the if.
        for +1 There is a decision at the start of the loop.
        while +1 There is a decision at the while statement.
        except +1 Each except branch adds a new conditional path of execution.
        finally +0 The finally block is unconditionally executed.
        with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
        assert +1 The assert statement internally roughly equals a conditional statement.
        Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
        Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

        Source: http://radon.readthedocs.org/en/latest/intro.html

        Cyclomatic complexity is too high in method _write_pkts. (17)
        Open

            def _write_pkts(self):
                for _, _, _, clnt_msgs, clnt_msgs_acks, srv_msgs, srv_msgs_acks, _, _, _ in self.pckt_times:
                    if len(clnt_msgs) != len(clnt_msgs_acks): # pragma: no cover
                        # no coverage; assert
                        print(clnt_msgs)
        Severity: Minor
        Found in tlsfuzzer/extract.py by radon

        Cyclomatic Complexity

        Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

        Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

        Construct Effect on CC Reasoning
        if +1 An if statement is a single decision.
        elif +1 The elif statement adds another decision.
        else +0 The else statement does not cause a new decision. The decision is at the if.
        for +1 There is a decision at the start of the loop.
        while +1 There is a decision at the while statement.
        except +1 Each except branch adds a new conditional path of execution.
        finally +0 The finally block is unconditionally executed.
        with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
        assert +1 The assert statement internally roughly equals a conditional statement.
        Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
        Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

        Source: http://radon.readthedocs.org/en/latest/intro.html

        Function _create_and_write_sanity_entries has a Cognitive Complexity of 25 (exceeds 10 allowed). Consider refactoring.
        Open

            def _create_and_write_sanity_entries(self):
                """
                Reads the intermediate file and adds sanity records to the final
                mesurements file.
                """
        Severity: Minor
        Found in tlsfuzzer/extract.py - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Cyclomatic complexity is too high in method process_measurements_and_create_csv_file. (16)
        Open

            def process_measurements_and_create_csv_file(
                    self, values_iter, comparing_value
                    ):
                """
                Processing all the nonces and associated time measurements from the
        Severity: Minor
        Found in tlsfuzzer/extract.py by radon

        Cyclomatic Complexity

        Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

        Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

        Construct Effect on CC Reasoning
        if +1 An if statement is a single decision.
        elif +1 The elif statement adds another decision.
        else +0 The else statement does not cause a new decision. The decision is at the if.
        for +1 There is a decision at the start of the loop.
        while +1 There is a decision at the while statement.
        except +1 Each except branch adds a new conditional path of execution.
        finally +0 The finally block is unconditionally executed.
        with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
        assert +1 The assert statement internally roughly equals a conditional statement.
        Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
        Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

        Source: http://radon.readthedocs.org/en/latest/intro.html

        Cyclomatic complexity is too high in method _create_and_write_sanity_entries. (16)
        Open

            def _create_and_write_sanity_entries(self):
                """
                Reads the intermediate file and adds sanity records to the final
                mesurements file.
                """
        Severity: Minor
        Found in tlsfuzzer/extract.py by radon

        Cyclomatic Complexity

        Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

        Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

        Construct Effect on CC Reasoning
        if +1 An if statement is a single decision.
        elif +1 The elif statement adds another decision.
        else +0 The else statement does not cause a new decision. The decision is at the if.
        for +1 There is a decision at the start of the loop.
        while +1 There is a decision at the while statement.
        except +1 Each except branch adds a new conditional path of execution.
        finally +0 The finally block is unconditionally executed.
        with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
        assert +1 The assert statement internally roughly equals a conditional statement.
        Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
        Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

        Source: http://radon.readthedocs.org/en/latest/intro.html

        Cyclomatic complexity is too high in method ecdsa_iter. (15)
        Open

            def ecdsa_iter(self, return_type="k-size"):
                """
                Iterator. Iterator to use for signatures signed by ECDSA private key.
                """
                k_map_filename = join(self.output, "ecdsa-k-time-map.csv")
        Severity: Minor
        Found in tlsfuzzer/extract.py by radon

        Cyclomatic Complexity

        Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

        Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

        Construct Effect on CC Reasoning
        if +1 An if statement is a single decision.
        elif +1 The elif statement adds another decision.
        else +0 The else statement does not cause a new decision. The decision is at the if.
        for +1 There is a decision at the start of the loop.
        while +1 There is a decision at the while statement.
        except +1 Each except branch adds a new conditional path of execution.
        finally +0 The finally block is unconditionally executed.
        with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
        assert +1 The assert statement internally roughly equals a conditional statement.
        Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
        Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

        Source: http://radon.readthedocs.org/en/latest/intro.html

        Function help_msg has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        def help_msg():
            """Print help message."""
            print("Usage: extract [-l logfile] [-c capture] [[-o output] ...]")
            print(" -l logfile     Filename of the timing log (required)")
            print(" -c capture     Packet capture of the test run")
        Severity: Major
        Found in tlsfuzzer/extract.py - About 2 hrs to fix

          Function __init__ has 58 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def __init__(self, log=None, capture=None, output=None, ip_address=None,
                           port=None, raw_times=None, col_name=None,
                           write_csv='timing.csv', write_pkt_csv='raw_times_detail.csv',
                           measurements_csv="measurements.csv",
                           binary=None, endian='little', no_quickack=False, delay=None,
          Severity: Major
          Found in tlsfuzzer/extract.py - About 2 hrs to fix

            Function process_rsa_keys has a Cognitive Complexity of 21 (exceeds 10 allowed). Consider refactoring.
            Open

                def process_rsa_keys(self):
                    # list of values for the Hamming weight of d, p, q, dP, dQ, qInv
                    values = []
                    times = []
                    max_len = 20
            Severity: Minor
            Found in tlsfuzzer/extract.py - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Cyclomatic complexity is too high in method add_timing. (11)
            Open

                def add_timing(self):
                    """Associate the timing information with its class"""
                    if self.client_message and self.server_message:
                        if self.warm_up_messages_left == 0:
                            class_index = next(self.class_generator)
            Severity: Minor
            Found in tlsfuzzer/extract.py by radon

            Cyclomatic Complexity

            Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

            Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

            Construct Effect on CC Reasoning
            if +1 An if statement is a single decision.
            elif +1 The elif statement adds another decision.
            else +0 The else statement does not cause a new decision. The decision is at the if.
            for +1 There is a decision at the start of the loop.
            while +1 There is a decision at the while statement.
            except +1 Each except branch adds a new conditional path of execution.
            finally +0 The finally block is unconditionally executed.
            with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
            assert +1 The assert statement internally roughly equals a conditional statement.
            Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
            Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

            Source: http://radon.readthedocs.org/en/latest/intro.html

            Cyclomatic complexity is too high in method process_measurements_and_create_hamming_csv_file. (11)
            Open

                def process_measurements_and_create_hamming_csv_file(
                        self, values_iter, items_in_tuple = 20):
                    """
                    Processing all the nonces and associated time measurements from the
                    given files and creates a file with tuples associating the Hamming
            Severity: Minor
            Found in tlsfuzzer/extract.py by radon

            Cyclomatic Complexity

            Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

            Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

            Construct Effect on CC Reasoning
            if +1 An if statement is a single decision.
            elif +1 The elif statement adds another decision.
            else +0 The else statement does not cause a new decision. The decision is at the if.
            for +1 There is a decision at the start of the loop.
            while +1 There is a decision at the while statement.
            except +1 Each except branch adds a new conditional path of execution.
            finally +0 The finally block is unconditionally executed.
            with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
            assert +1 The assert statement internally roughly equals a conditional statement.
            Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
            Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

            Source: http://radon.readthedocs.org/en/latest/intro.html

            Function main has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            def main():
                """Process arguments and start extraction."""
                logfile = None
                capture = None
                output = None
            Severity: Minor
            Found in tlsfuzzer/extract.py - About 1 hr to fix

              Function _create_and_write_line has a Cognitive Complexity of 19 (exceeds 10 allowed). Consider refactoring.
              Open

                  def _create_and_write_line(self):
                      """
                      Takes multiple possible values for each key value, selecting one
                      in random for each key and writes the created line into the
                      intermediate file.
              Severity: Minor
              Found in tlsfuzzer/extract.py - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function ecdsa_iter has a Cognitive Complexity of 17 (exceeds 10 allowed). Consider refactoring.
              Open

                  def ecdsa_iter(self, return_type="k-size"):
                      """
                      Iterator. Iterator to use for signatures signed by ECDSA private key.
                      """
                      k_map_filename = join(self.output, "ecdsa-k-time-map.csv")
              Severity: Minor
              Found in tlsfuzzer/extract.py - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function process_measurements_and_create_hamming_csv_file has a Cognitive Complexity of 14 (exceeds 10 allowed). Consider refactoring.
              Open

                  def process_measurements_and_create_hamming_csv_file(
                          self, values_iter, items_in_tuple = 20):
                      """
                      Processing all the nonces and associated time measurements from the
                      given files and creates a file with tuples associating the Hamming
              Severity: Minor
              Found in tlsfuzzer/extract.py - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function process_and_create_multiple_csv_files has a Cognitive Complexity of 13 (exceeds 10 allowed). Consider refactoring.
              Open

                  def process_and_create_multiple_csv_files(self, files = {
                      "measurements.csv": "k-size"
                  }):
                      original_measuremments_csv = self.measurements_csv
                      skipped_h_weight_invert = False
              Severity: Minor
              Found in tlsfuzzer/extract.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                                      if self.srv_fin > self.clnt_fin:
                                          self.last_warmup_fin = self.srv_fin
                                      else:
                                          self.last_warmup_fin = self.clnt_fin
              
              
              Severity: Major
              Found in tlsfuzzer/extract.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                            if tcp_pkt.ack != exp_srv_ack:
                                                print("Mismatched syn/ack seq at {0}\n"
                                                      .format(pkt_count))
                                                raise ValueError("Packet drops in capture!")
                                            exp_clnt_ack = exp_clnt_ack + len(tcp_pkt.data) \
                Severity: Major
                Found in tlsfuzzer/extract.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                              if tcp_pkt.ack != exp_clnt_ack:
                                                  print("Mismatched syn/ack seq at {0}\n"
                                                        .format(pkt_count))
                                                  raise ValueError("Packet drops in capture!")
                                              exp_srv_ack = exp_srv_ack + len(tcp_pkt.data) \
                  Severity: Major
                  Found in tlsfuzzer/extract.py - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                if len(self.client_msgs) > \
                                                        len(self.client_msgs_acks):
                                                    self.client_msgs_acks[tcp_pkt.ack] = timestamp
                                            else:
                    Severity: Major
                    Found in tlsfuzzer/extract.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                  if len(self.server_msgs) > \
                                                          len(self.server_msgs_acks):
                                                      self.server_msgs_acks[tcp_pkt.ack] = timestamp
                                          elif (tcp_pkt.flags & dpkt.tcp.TH_ACK and
                      Severity: Major
                      Found in tlsfuzzer/extract.py - About 45 mins to fix

                        Function _read_private_key has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
                        Open

                            def _read_private_key(self, file):
                                lines = []
                                while True:
                                    line = file.readline()
                                    # empty line still has '\n', only EOF is an empty string
                        Severity: Minor
                        Found in tlsfuzzer/extract.py - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                    if self.verbose and self._total_measurements:
                                        status = [0, self._total_measurements, Event()]
                                        kwargs = {}
                                        kwargs['unit'] = ' signatures'
                                        kwargs['prefix'] = 'decimal'
                        Severity: Major
                        Found in tlsfuzzer/extract.py and 2 other locations - About 5 hrs to fix
                        tlsfuzzer/extract.py on lines 1303..1312
                        tlsfuzzer/extract.py on lines 1440..1449

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 105.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                if self.verbose and self._total_measurements:
                                    status = [0, self._total_measurements, Event()]
                                    kwargs = {}
                                    kwargs['unit'] = ' signatures'
                                    kwargs['prefix'] = 'decimal'
                        Severity: Major
                        Found in tlsfuzzer/extract.py and 2 other locations - About 5 hrs to fix
                        tlsfuzzer/extract.py on lines 1062..1071
                        tlsfuzzer/extract.py on lines 1440..1449

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 105.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                if self.verbose and self._total_measurements:
                                    status = [0, self._total_measurements, Event()]
                                    kwargs = {}
                                    kwargs['unit'] = ' signatures'
                                    kwargs['prefix'] = 'decimal'
                        Severity: Major
                        Found in tlsfuzzer/extract.py and 2 other locations - About 5 hrs to fix
                        tlsfuzzer/extract.py on lines 1062..1071
                        tlsfuzzer/extract.py on lines 1303..1312

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 105.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    if len(clnt_msgs) != len(clnt_msgs_acks): # pragma: no cover
                                        # no coverage; assert
                                        print(clnt_msgs)
                                        print()
                                        print(clnt_msgs_acks)
                        Severity: Major
                        Found in tlsfuzzer/extract.py and 1 other location - About 1 hr to fix
                        tlsfuzzer/extract.py on lines 809..815

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 59.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    if len(clnt_msgs) != len(clnt_msgs_acks):  # pragma: no cover
                                        # no overage; assert
                                        print(clnt_msgs)
                                        print()
                                        print(clnt_msgs_acks)
                        Severity: Major
                        Found in tlsfuzzer/extract.py and 1 other location - About 1 hr to fix
                        tlsfuzzer/extract.py on lines 711..717

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 59.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        if clnt_fin is None:
                                            row.append(0)
                                        else:
                                            row.append(clnt_fin - s_msgs[-1])
                        Severity: Minor
                        Found in tlsfuzzer/extract.py and 1 other location - About 45 mins to fix
                        tlsfuzzer/extract.py on lines 775..778

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 45.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        if srv_fin is None:
                                            row.append(0)
                                        else:
                                            row.append(srv_fin - s_msgs[-1])
                        Severity: Minor
                        Found in tlsfuzzer/extract.py and 1 other location - About 45 mins to fix
                        tlsfuzzer/extract.py on lines 781..784

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 45.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    if len(srv_msgs) != len(srv_msgs_acks):  # pragma: no cover
                                        # no coverage; assert
                                        print(srv_msgs)
                                        print()
                                        print(srv_msgs_acks)
                        Severity: Minor
                        Found in tlsfuzzer/extract.py and 1 other location - About 40 mins to fix
                        tlsfuzzer/extract.py on lines 816..821

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 44.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    if len(srv_msgs) != len(srv_msgs_acks):  # pragma: no cover
                                        # no coverage; assert
                                        print(srv_msgs)
                                        print()
                                        print(srv_msgs_acks)
                        Severity: Minor
                        Found in tlsfuzzer/extract.py and 1 other location - About 40 mins to fix
                        tlsfuzzer/extract.py on lines 718..723

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 44.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Continuation line unaligned for hanging indent
                        Open

                                                .format(min_tuple_size)
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Continuation lines indentation.

                        Continuation lines should align wrapped elements either vertically
                        using Python's implicit line joining inside parentheses, brackets
                        and braces, or using a hanging indent.
                        
                        When using a hanging indent these considerations should be applied:
                        - there should be no arguments on the first line, and
                        - further indentation should be used to clearly distinguish itself
                          as a continuation line.
                        
                        Okay: a = (\n)
                        E123: a = (\n    )
                        
                        Okay: a = (\n    42)
                        E121: a = (\n   42)
                        E122: a = (\n42)
                        E123: a = (\n    42\n    )
                        E124: a = (24,\n     42\n)
                        E125: if (\n    b):\n    pass
                        E126: a = (\n        42)
                        E127: a = (24,\n      42)
                        E128: a = (24,\n    42)
                        E129: if (a or\n    b):\n    pass
                        E131: a = (\n    42\n 24)

                        Line too long (100 > 79 characters)
                        Open

                                for _, _, _, clnt_msgs, clnt_msgs_acks, srv_msgs, srv_msgs_acks, _, _, _ in self.pckt_times:
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Limit all lines to a maximum of 79 characters.

                        There are still many devices around that are limited to 80 character
                        lines; plus, limiting windows to 80 characters makes it possible to
                        have several windows side-by-side.  The default wrapping on such
                        devices looks ugly.  Therefore, please limit all lines to a maximum
                        of 79 characters. For flowing long blocks of text (docstrings or
                        comments), limiting the length to 72 characters is recommended.
                        
                        Reports error E501.

                        At least two spaces before inline comment
                        Open

                                    if len(clnt_msgs) != len(clnt_msgs_acks): # pragma: no cover
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Separate inline comments by at least two spaces.

                        An inline comment is a comment on the same line as a statement.
                        Inline comments should be separated by at least two spaces from the
                        statement. They should start with a # and a single space.
                        
                        Each line of a block comment starts with a # and a single space
                        (unless it is indented text inside the comment).
                        
                        Okay: x = x + 1  # Increment x
                        Okay: x = x + 1    # Increment x
                        Okay: # Block comment
                        E261: x = x + 1 # Increment x
                        E262: x = x + 1  #Increment x
                        E262: x = x + 1  #  Increment x
                        E265: #Block comment
                        E266: ### Block comment

                        Unexpected spaces around keyword / parameter equals
                        Open

                            def process_and_create_multiple_csv_files(self, files = {
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Don't use spaces around the '=' sign in function arguments.

                        Don't use spaces around the '=' sign when used to indicate a
                        keyword argument or a default parameter value, except when
                        using a type annotation.
                        
                        Okay: def complex(real, imag=0.0):
                        Okay: return magic(r=real, i=imag)
                        Okay: boolean(a == b)
                        Okay: boolean(a != b)
                        Okay: boolean(a <= b)
                        Okay: boolean(a >= b)
                        Okay: def foo(arg: int = 42):
                        Okay: async def foo(arg: int = 42):
                        
                        E251: def complex(real, imag = 0.0):
                        E251: return magic(r = real, i = imag)
                        E252: def complex(real, image: float=0.0):

                        Continuation line with same indent as next logical line
                        Open

                                ):
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Continuation lines indentation.

                        Continuation lines should align wrapped elements either vertically
                        using Python's implicit line joining inside parentheses, brackets
                        and braces, or using a hanging indent.
                        
                        When using a hanging indent these considerations should be applied:
                        - there should be no arguments on the first line, and
                        - further indentation should be used to clearly distinguish itself
                          as a continuation line.
                        
                        Okay: a = (\n)
                        E123: a = (\n    )
                        
                        Okay: a = (\n    42)
                        E121: a = (\n   42)
                        E122: a = (\n42)
                        E123: a = (\n    42\n    )
                        E124: a = (24,\n     42\n)
                        E125: if (\n    b):\n    pass
                        E126: a = (\n        42)
                        E127: a = (24,\n      42)
                        E128: a = (24,\n    42)
                        E129: if (a or\n    b):\n    pass
                        E131: a = (\n    42\n 24)

                        Unexpected spaces around keyword / parameter equals
                        Open

                            def process_and_create_multiple_csv_files(self, files = {
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Don't use spaces around the '=' sign in function arguments.

                        Don't use spaces around the '=' sign when used to indicate a
                        keyword argument or a default parameter value, except when
                        using a type annotation.
                        
                        Okay: def complex(real, imag=0.0):
                        Okay: return magic(r=real, i=imag)
                        Okay: boolean(a == b)
                        Okay: boolean(a != b)
                        Okay: boolean(a <= b)
                        Okay: boolean(a >= b)
                        Okay: def foo(arg: int = 42):
                        Okay: async def foo(arg: int = 42):
                        
                        E251: def complex(real, imag = 0.0):
                        E251: return magic(r = real, i = imag)
                        E252: def complex(real, image: float=0.0):

                        Unexpected spaces around keyword / parameter equals
                        Open

                                    self, values_iter, items_in_tuple = 20):
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Don't use spaces around the '=' sign in function arguments.

                        Don't use spaces around the '=' sign when used to indicate a
                        keyword argument or a default parameter value, except when
                        using a type annotation.
                        
                        Okay: def complex(real, imag=0.0):
                        Okay: return magic(r=real, i=imag)
                        Okay: boolean(a == b)
                        Okay: boolean(a != b)
                        Okay: boolean(a <= b)
                        Okay: boolean(a >= b)
                        Okay: def foo(arg: int = 42):
                        Okay: async def foo(arg: int = 42):
                        
                        E251: def complex(real, imag = 0.0):
                        E251: return magic(r = real, i = imag)
                        E252: def complex(real, image: float=0.0):

                        Comparison to none should be 'if cond is none:'
                        Open

                            if hash_func_name == None:
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Comparison to singletons should use "is" or "is not".

                        Comparisons to singletons like None should always be done
                        with "is" or "is not", never the equality operators.
                        
                        Okay: if arg is not None:
                        E711: if arg != None:
                        E711: if None == arg:
                        E712: if arg == True:
                        E712: if False == arg:
                        
                        Also, beware of writing if x when you really mean if x is not None
                        -- e.g. when testing whether a variable or argument that defaults to
                        None was set to some other value.  The other value might have a type
                        (such as a container) that could be false in a boolean context!

                        Continuation line under-indented for visual indent
                        Open

                                                        kwargs=kwargs)
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Continuation lines indentation.

                        Continuation lines should align wrapped elements either vertically
                        using Python's implicit line joining inside parentheses, brackets
                        and braces, or using a hanging indent.
                        
                        When using a hanging indent these considerations should be applied:
                        - there should be no arguments on the first line, and
                        - further indentation should be used to clearly distinguish itself
                          as a continuation line.
                        
                        Okay: a = (\n)
                        E123: a = (\n    )
                        
                        Okay: a = (\n    42)
                        E121: a = (\n   42)
                        E122: a = (\n42)
                        E123: a = (\n    42\n    )
                        E124: a = (24,\n     42\n)
                        E125: if (\n    b):\n    pass
                        E126: a = (\n        42)
                        E127: a = (24,\n      42)
                        E128: a = (24,\n    42)
                        E129: if (a or\n    b):\n    pass
                        E131: a = (\n    42\n 24)

                        Continuation line under-indented for visual indent
                        Open

                                                    kwargs=kwargs)
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Continuation lines indentation.

                        Continuation lines should align wrapped elements either vertically
                        using Python's implicit line joining inside parentheses, brackets
                        and braces, or using a hanging indent.
                        
                        When using a hanging indent these considerations should be applied:
                        - there should be no arguments on the first line, and
                        - further indentation should be used to clearly distinguish itself
                          as a continuation line.
                        
                        Okay: a = (\n)
                        E123: a = (\n    )
                        
                        Okay: a = (\n    42)
                        E121: a = (\n   42)
                        E122: a = (\n42)
                        E123: a = (\n    42\n    )
                        E124: a = (24,\n     42\n)
                        E125: if (\n    b):\n    pass
                        E126: a = (\n        42)
                        E127: a = (24,\n      42)
                        E128: a = (24,\n    42)
                        E129: if (a or\n    b):\n    pass
                        E131: a = (\n    42\n 24)

                        Expected 2 blank lines after class or function definition, found 1
                        Open

                        if __name__ == '__main__':
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Separate top-level function and class definitions with two blank lines.

                        Method definitions inside a class are separated by a single blank
                        line.
                        
                        Extra blank lines may be used (sparingly) to separate groups of
                        related functions.  Blank lines may be omitted between a bunch of
                        related one-liners (e.g. a set of dummy implementations).
                        
                        Use blank lines in functions, sparingly, to indicate logical
                        sections.
                        
                        Okay: def a():\n    pass\n\n\ndef b():\n    pass
                        Okay: def a():\n    pass\n\n\nasync def b():\n    pass
                        Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
                        Okay: default = 1\nfoo = 1
                        Okay: classify = 1\nfoo = 1
                        
                        E301: class Foo:\n    b = 0\n    def bar():\n        pass
                        E302: def a():\n    pass\n\ndef b(n):\n    pass
                        E302: def a():\n    pass\n\nasync def b(n):\n    pass
                        E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
                        E303: def a():\n\n\n\n    pass
                        E304: @decorator\n\ndef a():\n    pass
                        E305: def a():\n    pass\na()
                        E306: def a():\n    def b():\n        pass\n    def c():\n        pass

                        Continuation line under-indented for visual indent
                        Open

                                            .format(len(clnt_msgs), len(clnt_msgs_acks)))
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Continuation lines indentation.

                        Continuation lines should align wrapped elements either vertically
                        using Python's implicit line joining inside parentheses, brackets
                        and braces, or using a hanging indent.
                        
                        When using a hanging indent these considerations should be applied:
                        - there should be no arguments on the first line, and
                        - further indentation should be used to clearly distinguish itself
                          as a continuation line.
                        
                        Okay: a = (\n)
                        E123: a = (\n    )
                        
                        Okay: a = (\n    42)
                        E121: a = (\n   42)
                        E122: a = (\n42)
                        E123: a = (\n    42\n    )
                        E124: a = (24,\n     42\n)
                        E125: if (\n    b):\n    pass
                        E126: a = (\n        42)
                        E127: a = (24,\n      42)
                        E128: a = (24,\n    42)
                        E129: if (a or\n    b):\n    pass
                        E131: a = (\n    42\n 24)

                        Unexpected spaces around keyword / parameter equals
                        Open

                                    self, values_iter, items_in_tuple = 20):
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Don't use spaces around the '=' sign in function arguments.

                        Don't use spaces around the '=' sign when used to indicate a
                        keyword argument or a default parameter value, except when
                        using a type annotation.
                        
                        Okay: def complex(real, imag=0.0):
                        Okay: return magic(r=real, i=imag)
                        Okay: boolean(a == b)
                        Okay: boolean(a != b)
                        Okay: boolean(a <= b)
                        Okay: boolean(a >= b)
                        Okay: def foo(arg: int = 42):
                        Okay: async def foo(arg: int = 42):
                        
                        E251: def complex(real, imag = 0.0):
                        E251: return magic(r = real, i = imag)
                        E252: def complex(real, image: float=0.0):

                        Line too long (91 > 79 characters)
                        Open

                                    if len(srv_msgs) + int(self._fin_as_resp) != self._exp_srv:  # pragma: no cover
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Limit all lines to a maximum of 79 characters.

                        There are still many devices around that are limited to 80 character
                        lines; plus, limiting windows to 80 characters makes it possible to
                        have several windows side-by-side.  The default wrapping on such
                        devices looks ugly.  Therefore, please limit all lines to a maximum
                        of 79 characters. For flowing long blocks of text (docstrings or
                        comments), limiting the length to 72 characters is recommended.
                        
                        Reports error E501.

                        Continuation line under-indented for visual indent
                        Open

                                                    kwargs=kwargs)
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Continuation lines indentation.

                        Continuation lines should align wrapped elements either vertically
                        using Python's implicit line joining inside parentheses, brackets
                        and braces, or using a hanging indent.
                        
                        When using a hanging indent these considerations should be applied:
                        - there should be no arguments on the first line, and
                        - further indentation should be used to clearly distinguish itself
                          as a continuation line.
                        
                        Okay: a = (\n)
                        E123: a = (\n    )
                        
                        Okay: a = (\n    42)
                        E121: a = (\n   42)
                        E122: a = (\n42)
                        E123: a = (\n    42\n    )
                        E124: a = (24,\n     42\n)
                        E125: if (\n    b):\n    pass
                        E126: a = (\n        42)
                        E127: a = (24,\n      42)
                        E128: a = (24,\n    42)
                        E129: if (a or\n    b):\n    pass
                        E131: a = (\n    42\n 24)

                        Continuation line under-indented for visual indent
                        Open

                                            self._write_class_names]):
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Continuation lines indentation.

                        Continuation lines should align wrapped elements either vertically
                        using Python's implicit line joining inside parentheses, brackets
                        and braces, or using a hanging indent.
                        
                        When using a hanging indent these considerations should be applied:
                        - there should be no arguments on the first line, and
                        - further indentation should be used to clearly distinguish itself
                          as a continuation line.
                        
                        Okay: a = (\n)
                        E123: a = (\n    )
                        
                        Okay: a = (\n    42)
                        E121: a = (\n   42)
                        E122: a = (\n42)
                        E123: a = (\n    42\n    )
                        E124: a = (24,\n     42\n)
                        E125: if (\n    b):\n    pass
                        E126: a = (\n        42)
                        E127: a = (24,\n      42)
                        E128: a = (24,\n    42)
                        E129: if (a or\n    b):\n    pass
                        E131: a = (\n    42\n 24)

                        Continuation line under-indented for visual indent
                        Open

                                            .format(len(clnt_msgs), len(clnt_msgs_acks)))
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Continuation lines indentation.

                        Continuation lines should align wrapped elements either vertically
                        using Python's implicit line joining inside parentheses, brackets
                        and braces, or using a hanging indent.
                        
                        When using a hanging indent these considerations should be applied:
                        - there should be no arguments on the first line, and
                        - further indentation should be used to clearly distinguish itself
                          as a continuation line.
                        
                        Okay: a = (\n)
                        E123: a = (\n    )
                        
                        Okay: a = (\n    42)
                        E121: a = (\n   42)
                        E122: a = (\n42)
                        E123: a = (\n    42\n    )
                        E124: a = (24,\n     42\n)
                        E125: if (\n    b):\n    pass
                        E126: a = (\n        42)
                        E127: a = (24,\n      42)
                        E128: a = (24,\n    42)
                        E129: if (a or\n    b):\n    pass
                        E131: a = (\n    42\n 24)

                        At least two spaces before inline comment
                        Open

                                            else: # use the one after
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Separate inline comments by at least two spaces.

                        An inline comment is a comment on the same line as a statement.
                        Inline comments should be separated by at least two spaces from the
                        statement. They should start with a # and a single space.
                        
                        Each line of a block comment starts with a # and a single space
                        (unless it is indented text inside the comment).
                        
                        Okay: x = x + 1  # Increment x
                        Okay: x = x + 1    # Increment x
                        Okay: # Block comment
                        E261: x = x + 1 # Increment x
                        E262: x = x + 1  #Increment x
                        E262: x = x + 1  #  Increment x
                        E265: #Block comment
                        E266: ### Block comment

                        Continuation line unaligned for hanging indent
                        Open

                                            .format(self._max_tuple_size) +
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Continuation lines indentation.

                        Continuation lines should align wrapped elements either vertically
                        using Python's implicit line joining inside parentheses, brackets
                        and braces, or using a hanging indent.
                        
                        When using a hanging indent these considerations should be applied:
                        - there should be no arguments on the first line, and
                        - further indentation should be used to clearly distinguish itself
                          as a continuation line.
                        
                        Okay: a = (\n)
                        E123: a = (\n    )
                        
                        Okay: a = (\n    42)
                        E121: a = (\n   42)
                        E122: a = (\n42)
                        E123: a = (\n    42\n    )
                        E124: a = (24,\n     42\n)
                        E125: if (\n    b):\n    pass
                        E126: a = (\n        42)
                        E127: a = (24,\n      42)
                        E128: a = (24,\n    42)
                        E129: if (a or\n    b):\n    pass
                        E131: a = (\n    42\n 24)

                        Continuation line unaligned for hanging indent
                        Open

                                                .format(min_tuple_size) +
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Continuation lines indentation.

                        Continuation lines should align wrapped elements either vertically
                        using Python's implicit line joining inside parentheses, brackets
                        and braces, or using a hanging indent.
                        
                        When using a hanging indent these considerations should be applied:
                        - there should be no arguments on the first line, and
                        - further indentation should be used to clearly distinguish itself
                          as a continuation line.
                        
                        Okay: a = (\n)
                        E123: a = (\n    )
                        
                        Okay: a = (\n    42)
                        E121: a = (\n   42)
                        E122: a = (\n42)
                        E123: a = (\n    42\n    )
                        E124: a = (24,\n     42\n)
                        E125: if (\n    b):\n    pass
                        E126: a = (\n        42)
                        E127: a = (24,\n      42)
                        E128: a = (24,\n    42)
                        E129: if (a or\n    b):\n    pass
                        E131: a = (\n    42\n 24)

                        At least two spaces before inline comment
                        Open

                        except ImportError: # will be 3.x series
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Separate inline comments by at least two spaces.

                        An inline comment is a comment on the same line as a statement.
                        Inline comments should be separated by at least two spaces from the
                        statement. They should start with a # and a single space.
                        
                        Each line of a block comment starts with a # and a single space
                        (unless it is indented text inside the comment).
                        
                        Okay: x = x + 1  # Increment x
                        Okay: x = x + 1    # Increment x
                        Okay: # Block comment
                        E261: x = x + 1 # Increment x
                        E262: x = x + 1  #Increment x
                        E262: x = x + 1  #  Increment x
                        E265: #Block comment
                        E266: ### Block comment

                        At least two spaces before inline comment
                        Open

                                            if random_choice == 0: # use the one before
                        Severity: Minor
                        Found in tlsfuzzer/extract.py by pep8

                        Separate inline comments by at least two spaces.

                        An inline comment is a comment on the same line as a statement.
                        Inline comments should be separated by at least two spaces from the
                        statement. They should start with a # and a single space.
                        
                        Each line of a block comment starts with a # and a single space
                        (unless it is indented text inside the comment).
                        
                        Okay: x = x + 1  # Increment x
                        Okay: x = x + 1    # Increment x
                        Okay: # Block comment
                        E261: x = x + 1 # Increment x
                        E262: x = x + 1  #Increment x
                        E262: x = x + 1  #  Increment x
                        E265: #Block comment
                        E266: ### Block comment

                        There are no issues that match your filters.

                        Category
                        Status