tlsfuzzer/tlslite-ng

View on GitHub

Showing 324 of 1,708 total issues

Avoid deeply nested control flow statements.
Open

                        for i, ext in enumerate(clientHello.extensions):
                            if ext.extType == \
                                    ExtensionType.client_hello_padding:
                                clientHello1.extensions.insert(i, ext)
                                break
Severity: Major
Found in tlslite/tlsconnection.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            for result in self._sendError(AlertDescription
                                                          .handshake_failure,
                                                          "No acceptable group "
                                                          "advertised by client"):
                                yield result
    Severity: Major
    Found in tlslite/tlsconnection.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              for result in self._sendError(
                                      AlertDescription.illegal_parameter,
                                      "PSK extension not last in client hello"):
                                  yield result
                      # early_data extension MUST be dropped
      Severity: Major
      Found in tlslite/tlsconnection.py - About 45 mins to fix

        Function write has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def write(self):
                """Serialise object to bytearray."""
                writer = Writer()
        
                shortHeader = not (self.padding or self.securityEscape)
        Severity: Minor
        Found in tlslite/messages.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(self, cipherSuite, clientHello, serverHello, privateKey,
        Severity: Minor
        Found in tlslite/keyexchange.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if ext.extType == ExtensionType.cookie:
                                      if ext.extData != cookie.extData:
                                          eType = AlertDescription.illegal_parameter
                                          eText = "Malformed cookie extension"
                                          for result in self._sendError(eType, eText):
          Severity: Major
          Found in tlslite/tlsconnection.py - About 45 mins to fix

            Function processClientKeyExchange has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def processClientKeyExchange(self, clientKeyExchange):
                    """Decrypt client key exchange, return premaster secret"""
                    premasterSecret = self.privateKey.decrypt(\
                        clientKeyExchange.encryptedPreMasterSecret)
            
            
            Severity: Minor
            Found in tlslite/keyexchange.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function create has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def create(self, session_id_hit, certificate_type, server_version,
            Severity: Minor
            Found in tlslite/messages.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      for result in self._sendError(
                                              AlertDescription.handshake_failure):
                                          yield result
                                  secureRenego = True
              Severity: Major
              Found in tlslite/tlsconnection.py - About 45 mins to fix

                Function _sockSendAll has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    def _sockSendAll(self, data):
                        """
                        Send all data through socket
                
                        :type data: bytearray
                Severity: Minor
                Found in tlslite/recordlayer.py - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _clientTLS13Handshake has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def _clientTLS13Handshake(self, settings, session, clientHello,
                Severity: Minor
                Found in tlslite/tlsconnection.py - About 45 mins to fix

                  Function _server_select_certificate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def _server_select_certificate(self, settings, client_hello,
                  Severity: Minor
                  Found in tlslite/tlsconnection.py - About 45 mins to fix

                    Function create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def create(self, master_secret, protocol_version, cipher_suite,
                                   creation_time, nonce=bytearray(), client_cert_chain=None,
                                   encrypt_then_mac=False, extended_master_secret=False,
                                   server_name=bytearray()):
                            """Initialise the object with cryptographic data."""
                    Severity: Minor
                    Found in tlslite/messages.py - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _clientSelectNextProto has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def _clientSelectNextProto(self, nextProtos, serverHello):
                            # nextProtos is None or non-empty list of strings
                            # serverHello.next_protos is None or possibly-empty list of strings
                            #
                            # !!! We assume the client may have specified nextProtos as a list of
                    Severity: Minor
                    Found in tlslite/tlsconnection.py - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _sendFinished has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def _sendFinished(self, masterSecret, cipherSuite=None, nextProto=None,
                    Severity: Minor
                    Found in tlslite/tlsconnection.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                              for result in self._sendError(
                                                      AlertDescription.illegal_parameter,
                                                      "Other party's TACK doesn't match their public key"):
                                                      yield result
                      
                      
                      Severity: Major
                      Found in tlslite/tlsconnection.py - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                for result in self._sendError(
                                                        AlertDescription.illegal_parameter,
                                                        "Client sent invalid Heartbeat extension"):
                                                    yield result
                                            heartbeat = HeartbeatExtension().create(
                        Severity: Major
                        Found in tlslite/tlsconnection.py - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                  for result in self._sendError(AlertDescription
                                                                                .missing_extension,
                                                                                "Second client hello "
                                                                                "does not contain "
                                                                                "cookie extension"):
                          Severity: Major
                          Found in tlslite/tlsconnection.py - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    if cert.x509List[i].sigalg not in client_sigalgs:
                                                        cert_chain_ok = False
                                                        break
                                            if not cert_chain_ok:
                            Severity: Major
                            Found in tlslite/tlsconnection.py - About 45 mins to fix

                              Consider simplifying this complex logical expression.
                              Open

                                          if (
                                              symbols[0] == symbols[1] or symbols[0] == symbols[2] or
                                              symbols[0] == symbols[3] or symbols[1] == symbols[2] or
                                              symbols[1] == symbols[3] or symbols[2] == symbols[3]
                                          ):
                              Severity: Major
                              Found in tlslite/utils/brotlidecpy/decode.py - About 40 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language