Sign upLogin

tlsfuzzer/tlslite-ng

View on GitHub
Star

Showing 1,708 of 1,708 total issues

Function _serverGetClientHello has a Cognitive Complexity of 584 (exceeds 5 allowed). Consider refactoring.
Open

    def _serverGetClientHello(self, settings, private_key, cert_chain,
                              verifierDB,
                              sessionCache, anon, alpn, sni):
        # Tentatively set version to most-desirable version, so if an error
        # occurs parsing the ClientHello, this will be the version we'll use
Severity: Minor
Found in tlslite/tlsconnection.py - About 1 wk to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File tlsconnection.py has 3887 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Authors:
#   Trevor Perrin
#   Google - added reqCAs parameter
#   Google (adapted by Sam Rushing and Marcelo Fernandez) - NPN support
#   Google - FALLBACK_SCSV
Severity: Major
Found in tlslite/tlsconnection.py - About 1 wk to fix

    File messages.py has 2125 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # Authors:
#   Trevor Perrin
#   Google - handling CertificateRequest.certificate_types
#   Google (adapted by Sam Rushing and Marcelo Fernandez) - NPN support
#   Dimitris Moraitis - Anon ciphersuites
    Severity: Major
    Found in tlslite/messages.py - About 5 days to fix

      Cyclomatic complexity is too high in method _serverGetClientHello. (261)
      Open

          def _serverGetClientHello(self, settings, private_key, cert_chain,
                              verifierDB,
                              sessionCache, anon, alpn, sni):
        # Tentatively set version to most-desirable version, so if an error
        # occurs parsing the ClientHello, this will be the version we'll use
      Severity: Minor
      Found in tlslite/tlsconnection.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      File extensions.py has 1694 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      # Copyright (c) 2014, 2015 Hubert Kario
#
# See the LICENSE file for legal information regarding use of this file.

""" Helper package for handling TLS extensions encountered in ClientHello
      Severity: Major
      Found in tlslite/extensions.py - About 4 days to fix

        Function _getMsg has a Cognitive Complexity of 182 (exceeds 5 allowed). Consider refactoring.
        Open

            def _getMsg(self, expectedType, secondaryType=None, constructorType=None):
        try:
            if not isinstance(expectedType, tuple):
                expectedType = (expectedType,)
        Severity: Minor
        Found in tlslite/tlsrecordlayer.py - About 3 days to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File constants.py has 1353 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # Authors:
#   Trevor Perrin
#   Google - defining ClientCertificateType
#   Google (adapted by Sam Rushing) - NPN support
#   Dimitris Moraitis - Anon ciphersuites
        Severity: Major
        Found in tlslite/constants.py - About 3 days to fix

          Function _serverTLS13Handshake has a Cognitive Complexity of 149 (exceeds 5 allowed). Consider refactoring.
          Open

              def _serverTLS13Handshake(self, settings, clientHello, cipherSuite,
                              privateKey, serverCertChain, version, scheme,
                              srv_alpns, reqCert):
        """Perform a TLS 1.3 handshake"""
        prf_name, prf_size = self._getPRFParams(cipherSuite)
          Severity: Minor
          Found in tlslite/tlsconnection.py - About 3 days to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File tlsrecordlayer.py has 1163 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # Authors:
#   Trevor Perrin
#   Google (adapted by Sam Rushing) - NPN support
#   Google - minimal padding
#   Martin von Loewis - python 3 port
          Severity: Major
          Found in tlslite/tlsrecordlayer.py - About 2 days to fix

            Function _clientTLS13Handshake has a Cognitive Complexity of 141 (exceeds 5 allowed). Consider refactoring.
            Open

                def _clientTLS13Handshake(self, settings, session, clientHello,
                              clientCertChain, privateKey, serverHello):
        """Perform TLS 1.3 handshake as a client."""
        prfName, prf_size = self._getPRFParams(serverHello.cipher_suite)
            Severity: Minor
            Found in tlslite/tlsconnection.py - About 2 days to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _clientGetServerHello has a Cognitive Complexity of 141 (exceeds 5 allowed). Consider refactoring.
            Open

                def _clientGetServerHello(self, settings, session, clientHello):
        client_hello_hash = self._handshake_hash.copy()
        for result in self._getMsg(ContentType.handshake,
                                   HandshakeType.server_hello):
            if result in (0,1): yield result
            Severity: Minor
            Found in tlslite/tlsconnection.py - About 2 days to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File recordlayer.py has 1047 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            # Copyright (c) 2014, Hubert Kario
#
# See the LICENSE file for legal information regarding use of this file.

"""Implementation of the TLS Record Layer protocol"""
            Severity: Major
            Found in tlslite/recordlayer.py - About 2 days to fix

              File rijndael.py has 1029 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              # Authors:
#   Bram Cohen
#   Trevor Perrin - various changes
#
# See the LICENSE file for legal information regarding use of this file.
              Severity: Major
              Found in tlslite/utils/rijndael.py - About 2 days to fix

                File keyexchange.py has 1005 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                # Authors:
#   Hubert Kario (2015)
#
# See the LICENSE file for legal information regarding use of this file.
"""Handling of cryptographic operations for key exchange"""
                Severity: Major
                Found in tlslite/keyexchange.py - About 2 days to fix

                  Similar blocks of code found in 14 locations. Consider refactoring.
                  Open

                  Si = (82, 9, 106, 213, 48, 54, 165, 56,
      191, 64, 163, 158, 129, 243, 215, 251,
      124, 227, 57, 130, 155, 47, 255, 135,
      52, 142, 67, 68, 196, 222, 233, 203,
      84, 123, 148, 50, 166, 194, 35, 61,
                  Severity: Major
                  Found in tlslite/utils/rijndael.py and 13 other locations - About 2 days to fix
                  tlslite/utils/rijndael.py on lines 51..82
                  tlslite/utils/rijndael.py on lines 118..181
                  tlslite/utils/rijndael.py on lines 183..246
                  tlslite/utils/rijndael.py on lines 248..311
                  tlslite/utils/rijndael.py on lines 313..376
                  tlslite/utils/rijndael.py on lines 378..441
                  tlslite/utils/rijndael.py on lines 443..506
                  tlslite/utils/rijndael.py on lines 508..571
                  tlslite/utils/rijndael.py on lines 573..636
                  tlslite/utils/rijndael.py on lines 638..701
                  tlslite/utils/rijndael.py on lines 703..766
                  tlslite/utils/rijndael.py on lines 768..831
                  tlslite/utils/rijndael.py on lines 833..896

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 262.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 14 locations. Consider refactoring.
                  Open

                  T6 = (0x5051f4a7, 0x537e4165, 0xc31a17a4, 0x963a275e,
      0xcb3bab6b, 0xf11f9d45, 0xabacfa58, 0x934be303,
      0x552030fa, 0xf6ad766d, 0x9188cc76, 0x25f5024c,
      0xfc4fe5d7, 0xd7c52acb, 0x80263544, 0x8fb562a3,
      0x49deb15a, 0x6725ba1b, 0x9845ea0e, 0xe15dfec0,
                  Severity: Major
                  Found in tlslite/utils/rijndael.py and 13 other locations - About 2 days to fix
                  tlslite/utils/rijndael.py on lines 51..82
                  tlslite/utils/rijndael.py on lines 85..116
                  tlslite/utils/rijndael.py on lines 118..181
                  tlslite/utils/rijndael.py on lines 183..246
                  tlslite/utils/rijndael.py on lines 248..311
                  tlslite/utils/rijndael.py on lines 313..376
                  tlslite/utils/rijndael.py on lines 378..441
                  tlslite/utils/rijndael.py on lines 508..571
                  tlslite/utils/rijndael.py on lines 573..636
                  tlslite/utils/rijndael.py on lines 638..701
                  tlslite/utils/rijndael.py on lines 703..766
                  tlslite/utils/rijndael.py on lines 768..831
                  tlslite/utils/rijndael.py on lines 833..896

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 262.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 14 locations. Consider refactoring.
                  Open

                  T1 = (0xc66363a5, 0xf87c7c84, 0xee777799, 0xf67b7b8d,
      0xfff2f20d, 0xd66b6bbd, 0xde6f6fb1, 0x91c5c554,
      0x60303050, 0x2010103, 0xce6767a9, 0x562b2b7d,
      0xe7fefe19, 0xb5d7d762, 0x4dababe6, 0xec76769a,
      0x8fcaca45, 0x1f82829d, 0x89c9c940, 0xfa7d7d87,
                  Severity: Major
                  Found in tlslite/utils/rijndael.py and 13 other locations - About 2 days to fix
                  tlslite/utils/rijndael.py on lines 51..82
                  tlslite/utils/rijndael.py on lines 85..116
                  tlslite/utils/rijndael.py on lines 183..246
                  tlslite/utils/rijndael.py on lines 248..311
                  tlslite/utils/rijndael.py on lines 313..376
                  tlslite/utils/rijndael.py on lines 378..441
                  tlslite/utils/rijndael.py on lines 443..506
                  tlslite/utils/rijndael.py on lines 508..571
                  tlslite/utils/rijndael.py on lines 573..636
                  tlslite/utils/rijndael.py on lines 638..701
                  tlslite/utils/rijndael.py on lines 703..766
                  tlslite/utils/rijndael.py on lines 768..831
                  tlslite/utils/rijndael.py on lines 833..896

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 262.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 14 locations. Consider refactoring.
                  Open

                  T8 = (0xf4a75051, 0x4165537e, 0x17a4c31a, 0x275e963a,
      0xab6bcb3b, 0x9d45f11f, 0xfa58abac, 0xe303934b,
      0x30fa5520, 0x766df6ad, 0xcc769188, 0x24c25f5,
      0xe5d7fc4f, 0x2acbd7c5, 0x35448026, 0x62a38fb5,
      0xb15a49de, 0xba1b6725, 0xea0e9845, 0xfec0e15d,
                  Severity: Major
                  Found in tlslite/utils/rijndael.py and 13 other locations - About 2 days to fix
                  tlslite/utils/rijndael.py on lines 51..82
                  tlslite/utils/rijndael.py on lines 85..116
                  tlslite/utils/rijndael.py on lines 118..181
                  tlslite/utils/rijndael.py on lines 183..246
                  tlslite/utils/rijndael.py on lines 248..311
                  tlslite/utils/rijndael.py on lines 313..376
                  tlslite/utils/rijndael.py on lines 378..441
                  tlslite/utils/rijndael.py on lines 443..506
                  tlslite/utils/rijndael.py on lines 508..571
                  tlslite/utils/rijndael.py on lines 638..701
                  tlslite/utils/rijndael.py on lines 703..766
                  tlslite/utils/rijndael.py on lines 768..831
                  tlslite/utils/rijndael.py on lines 833..896

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 262.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 14 locations. Consider refactoring.
                  Open

                  T3 = (0x63a5c663, 0x7c84f87c, 0x7799ee77, 0x7b8df67b,
      0xf20dfff2, 0x6bbdd66b, 0x6fb1de6f, 0xc55491c5,
      0x30506030, 0x1030201, 0x67a9ce67, 0x2b7d562b,
      0xfe19e7fe, 0xd762b5d7, 0xabe64dab, 0x769aec76,
      0xca458fca, 0x829d1f82, 0xc94089c9, 0x7d87fa7d,
                  Severity: Major
                  Found in tlslite/utils/rijndael.py and 13 other locations - About 2 days to fix
                  tlslite/utils/rijndael.py on lines 51..82
                  tlslite/utils/rijndael.py on lines 85..116
                  tlslite/utils/rijndael.py on lines 118..181
                  tlslite/utils/rijndael.py on lines 183..246
                  tlslite/utils/rijndael.py on lines 313..376
                  tlslite/utils/rijndael.py on lines 378..441
                  tlslite/utils/rijndael.py on lines 443..506
                  tlslite/utils/rijndael.py on lines 508..571
                  tlslite/utils/rijndael.py on lines 573..636
                  tlslite/utils/rijndael.py on lines 638..701
                  tlslite/utils/rijndael.py on lines 703..766
                  tlslite/utils/rijndael.py on lines 768..831
                  tlslite/utils/rijndael.py on lines 833..896

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 262.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 14 locations. Consider refactoring.
                  Open

                  T5 = (0x51f4a750, 0x7e416553, 0x1a17a4c3, 0x3a275e96,
      0x3bab6bcb, 0x1f9d45f1, 0xacfa58ab, 0x4be30393,
      0x2030fa55, 0xad766df6, 0x88cc7691, 0xf5024c25,
      0x4fe5d7fc, 0xc52acbd7, 0x26354480, 0xb562a38f,
      0xdeb15a49, 0x25ba1b67, 0x45ea0e98, 0x5dfec0e1,
                  Severity: Major
                  Found in tlslite/utils/rijndael.py and 13 other locations - About 2 days to fix
                  tlslite/utils/rijndael.py on lines 51..82
                  tlslite/utils/rijndael.py on lines 85..116
                  tlslite/utils/rijndael.py on lines 118..181
                  tlslite/utils/rijndael.py on lines 183..246
                  tlslite/utils/rijndael.py on lines 248..311
                  tlslite/utils/rijndael.py on lines 313..376
                  tlslite/utils/rijndael.py on lines 443..506
                  tlslite/utils/rijndael.py on lines 508..571
                  tlslite/utils/rijndael.py on lines 573..636
                  tlslite/utils/rijndael.py on lines 638..701
                  tlslite/utils/rijndael.py on lines 703..766
                  tlslite/utils/rijndael.py on lines 768..831
                  tlslite/utils/rijndael.py on lines 833..896

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 262.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language