Sign upLogin

toadle/giant_bomb_api

View on GitHub
Star

Showing 5 of 5 total issues

Method where has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def where(params = {})
      return GiantBombApi.client.send_request(Request::Collection.new(self)) unless params.present?

      sort = params[:sort]
      limit = params[:limit]
Severity: Minor
Found in lib/giant_bomb_api/collection_resource.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method rate_limit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def rate_limit(should_rate_limit, rate_per_hour, &block)
      started_at = Time.now
      num_of_requests = 0

      loop do
Severity: Minor
Found in lib/giant_bomb_api/collection_resource.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method init_resource_from has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def self.init_resource_from(json, attribute_name: nil, resource_name: nil)
      resource_name ||= discover_resource_name(json["api_detail_url"])
      resource_name ||= attribute_name if resource_exists?(attribute_name)
      resource_name ||= attribute_name.to_s.singularize if resource_exists?(attribute_name.to_s.singularize)
      return if resource_name.nil?
Severity: Minor
Found in lib/giant_bomb_api/resource/factory.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  class Resource::Video
    extend GiantBombApi::CollectionResource
    resource_attribute :deck
    resource_attribute :hd_url
    resource_attribute :high_url
Severity: Minor
Found in lib/giant_bomb_api/resource/video.rb and 1 other location - About 25 mins to fix
lib/giant_bomb_api/resource/franchise.rb on lines 2..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  class Resource::Franchise
    extend GiantBombApi::CollectionResource
    resource_attribute :aliases
    resource_attribute :characters
    resource_attribute :concepts
Severity: Minor
Found in lib/giant_bomb_api/resource/franchise.rb and 1 other location - About 25 mins to fix
lib/giant_bomb_api/resource/video.rb on lines 2..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language