Sign upLogin

toadle/giant_bomb_api

View on GitHub
Star

Showing 3 of 5 total issues

Method where has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def where(params = {})
      return GiantBombApi.client.send_request(Request::Collection.new(self)) unless params.present?

      sort = params[:sort]
      limit = params[:limit]
Severity: Minor
Found in lib/giant_bomb_api/collection_resource.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method rate_limit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def rate_limit(should_rate_limit, rate_per_hour, &block)
      started_at = Time.now
      num_of_requests = 0

      loop do
Severity: Minor
Found in lib/giant_bomb_api/collection_resource.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method init_resource_from has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def self.init_resource_from(json, attribute_name: nil, resource_name: nil)
      resource_name ||= discover_resource_name(json["api_detail_url"])
      resource_name ||= attribute_name if resource_exists?(attribute_name)
      resource_name ||= attribute_name.to_s.singularize if resource_exists?(attribute_name.to_s.singularize)
      return if resource_name.nil?
Severity: Minor
Found in lib/giant_bomb_api/resource/factory.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language