Sign upLogin

tobyqin/testcube

View on GitHub
Star
testcube/core/views.py

Summary

Maintainability
D
2 days
Test Coverage

Function result_analysis has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def result_analysis(request, result_id):
    """POST view for result analysis"""
    result_id = int(result_id)

    if request.method == 'POST':
Severity: Minor
Found in testcube/core/views.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function result_reset has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def result_reset(request, result_id):
    """POST view for result reset"""
    result_id = int(result_id)

    if request.method == 'POST':
Severity: Minor
Found in testcube/core/views.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

def result_reset(request, result_id):
    """POST view for result reset"""
    result_id = int(result_id)

    if request.method == 'POST':
Severity: Major
Found in testcube/core/views.py and 1 other location - About 1 day to fix
testcube/core/views.py on lines 72..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

def result_analysis(request, result_id):
    """POST view for result analysis"""
    result_id = int(result_id)

    if request.method == 'POST':
Severity: Major
Found in testcube/core/views.py and 1 other location - About 1 day to fix
testcube/core/views.py on lines 93..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Invalid escape sequence '\/'
Open

        source = re.sub('^(http[s]*:\/\/[^\/]+)', '', source)
Severity: Minor
Found in testcube/core/views.py by pep8

Invalid escape sequences are deprecated in Python 3.6.

Okay: regex = r'\.png$'
W605: regex = '\.png$'

Invalid escape sequence '\/'
Open

        source = re.sub('^(http[s]*:\/\/[^\/]+)', '', source)
Severity: Minor
Found in testcube/core/views.py by pep8

Invalid escape sequences are deprecated in Python 3.6.

Okay: regex = r'\.png$'
W605: regex = '\.png$'

Invalid escape sequence '\/'
Open

        source = re.sub('^(http[s]*:\/\/[^\/]+)', '', source)
Severity: Minor
Found in testcube/core/views.py by pep8

Invalid escape sequences are deprecated in Python 3.6.

Okay: regex = r'\.png$'
W605: regex = '\.png$'

There are no issues that match your filters.

Category
Status