Sign upLogin

tokyorails/tokyorails

View on GitHub
Star

Showing 3 of 3 total issues

Method import_events has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def self.import_events

    puts "Please be patient, as event photos are also imported during this import" unless Rails.env.test?

    event_list = get_meetup_api_results('https://api.meetup.com/2/events.json', :status => 'upcoming,past')
Severity: Minor
Found in lib/tokyorails/meetup_tasks.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def create
      # Since Globalize3 doesn't inherently support tabbed UI locale creation/editing, clean up is required
      super do |format|
        @project.translations.each {|translation|
          translation.delete if translation.title.nil? && translation.description.nil?
Severity: Minor
Found in app/admin/projects.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method index has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def index
    @projects = Project.all.map{|p| p.active? ? p : nil}.compact
    @icebox = Project.all.map{|p| p.active? ? nil : p}.compact
    @event = Event.upcoming.last
  end
Severity: Minor
Found in app/controllers/projects_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language