Sign upLogin

tom-weatherhead/thaw-grammar

View on GitHub
Star
src/common/domain-object-model/operator-usage.ts

Summary

Maintainability
C
1 day
Test Coverage
F
1%

Function evaluateAux has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected evaluateAux(
        evaluatedArguments: T[],
        globalInfo: IGlobalInfo<T>,
        localEnvironment?: IEnvironmentFrame<T>,
        options?: unknown
Severity: Major
Found in src/common/domain-object-model/operator-usage.ts - About 2 hrs to fix

    Function evaluateAux has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        protected evaluateAux(
        evaluatedArguments: T[],
        globalInfo: IGlobalInfo<T>,
        localEnvironment?: IEnvironmentFrame<T>,
        options?: unknown
    Severity: Minor
    Found in src/common/domain-object-model/operator-usage.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function tryGetExpectedNumArgs has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected tryGetExpectedNumArgs(globalInfo: IGlobalInfo<T>): number | undefined {
        if (['<', '>', '+', '-', '*', '/'].indexOf(this.operatorName.value) >= 0) {
            return 2;
        }
    Severity: Minor
    Found in src/common/domain-object-model/operator-usage.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

    export function isOperatorUsage<T>(obj: unknown): obj is OperatorUsage<T> {
    const operatorUsage = obj as OperatorUsage<T>;

    return typeof operatorUsage !== 'undefined' && operatorUsage.typename === typenameOperatorUsage;
}
    Severity: Major
    Found in src/common/domain-object-model/operator-usage.ts and 10 other locations - About 2 hrs to fix
    src/common/domain-object-model/begin-usage.ts on lines 9..13
    src/common/domain-object-model/cond-usage.ts on lines 9..13
    src/common/domain-object-model/function-definition.ts on lines 12..16
    src/common/domain-object-model/if-usage.ts on lines 9..13
    src/common/domain-object-model/let-star-usage.ts on lines 12..16
    src/common/domain-object-model/let-usage.ts on lines 10..14
    src/common/domain-object-model/set-usage.ts on lines 12..16
    src/common/domain-object-model/variable.ts on lines 16..20
    src/common/domain-object-model/while-usage.ts on lines 9..13
    src/languages/scheme/domain-object-model/let-rec-usage.ts on lines 13..17

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            } else if (expectedNumArgs >= 0 && actualNumArgs !== expectedNumArgs) {
            throw new EvaluationException(
                `OperatorUsage : Expected ${expectedNumArgs} argument(s) for operator '${this.operatorName.value}', instead of the actual ${actualNumArgs} argument(s)`,
                this.operatorName.line,
                this.operatorName.column
    Severity: Minor
    Found in src/common/domain-object-model/operator-usage.ts and 1 other location - About 55 mins to fix
    src/languages/smalltalk/domain-object-model/operator-usage.ts on lines 494..500

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            const secondArgAsInt =
            evaluatedArguments.length > 1 && globalInfo.valueIsInteger(evaluatedArguments[1])
                ? globalInfo.valueAsInteger(evaluatedArguments[1])
                : 0;
    Severity: Major
    Found in src/common/domain-object-model/operator-usage.ts and 3 other locations - About 40 mins to fix
    src/common/domain-object-model/operator-usage.ts on lines 176..179
    src/languages/clu/domain-object-model/operator-usage.ts on lines 182..185
    src/languages/clu/domain-object-model/operator-usage.ts on lines 186..189

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            const firstArgAsInt =
            evaluatedArguments.length > 0 && globalInfo.valueIsInteger(evaluatedArguments[0])
                ? globalInfo.valueAsInteger(evaluatedArguments[0])
                : 0;
    Severity: Major
    Found in src/common/domain-object-model/operator-usage.ts and 3 other locations - About 40 mins to fix
    src/common/domain-object-model/operator-usage.ts on lines 180..183
    src/languages/clu/domain-object-model/operator-usage.ts on lines 182..185
    src/languages/clu/domain-object-model/operator-usage.ts on lines 186..189

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            if (expectedNumArgs === undefined) {
            throw new EvaluationException(
                `OperatorUsage : Unknown operator name '${this.operatorName.value}`,
                this.operatorName.line,
                this.operatorName.column
    Severity: Major
    Found in src/common/domain-object-model/operator-usage.ts and 3 other locations - About 35 mins to fix
    src/languages/smalltalk/domain-object-model/operator-usage.ts on lines 920..926
    src/languages/smalltalk/domain-object-model/operator-usage.ts on lines 995..1001
    src/languages/smalltalk/domain-object-model/operator-usage.ts on lines 1003..1009

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status