Sign upLogin

tom-weatherhead/thaw-image-processing.ts

View on GitHub
Star

Showing 71 of 71 total issues

Function resample1DBilinear has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
    srcBuffer: ThAWImageBufferType,
Severity: Major
Found in src/processing/resample.ts - About 1 hr to fix

    Function resample1DBilinear has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    function resample1DBilinear(
    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
    Severity: Minor
    Found in src/processing/resample.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function constructor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        constructor(
        width: number,
        height: number,
        bytesPerPixel?: number,
        bytesPerLine?: number,
    Severity: Minor
    Found in src/util/image.ts - About 1 hr to fix

      Function mapImageByCoordinatesFromBuffer has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function mapImageByCoordinatesFromBuffer(
    dstBuffer: ThAWImageBufferType,
    dstWidth: number,
    dstHeight: number,
    dstInitialRowOffset: number,
      Severity: Minor
      Found in src/util/map-coordinates.ts - About 1 hr to fix

        Function dispatchGaussianBlur has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        async function dispatchGaussianBlur(argv: string[]): Promise<void> {
    let srcFilePath = defaultSrcFilePath;
    let dstFilePath = `test/output-files/gaussian-blur.${dstFileExtension}`;
    // let sigma = 1.0;
    let sigma = 4.0;
        Severity: Minor
        Found in src/cli.ts - About 1 hr to fix

          Function dispatchPixelate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          async function dispatchPixelate(argv: string[]): Promise<void> {
    let srcFilePath = defaultSrcFilePath;
    let dstFilePath = `test/output-files/pixelate.${dstFileExtension}`;
    let pixelWidth = 8;
    let pixelHeight = 8;
          Severity: Minor
          Found in src/cli.ts - About 1 hr to fix

            Function resample1DNearestNeighbour has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function resample1DNearestNeighbour(
    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
            Severity: Minor
            Found in src/processing/resample.ts - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  dstBuffer[dstPixelOffset + 2] = Math.round(
                        srcBuffer[srcPixelOffset + 2] * normalizedAlpha +
                            dstBuffer[dstPixelOffset + 2] *
                                normalizedAlphaComplement
                    );
              Severity: Minor
              Found in src/util/composite.ts and 1 other location - About 55 mins to fix
              src/util/composite.ts on lines 137..141

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  dstBuffer[dstPixelOffset + 0] = Math.round(
                        srcBuffer[srcPixelOffset + 0] * normalizedAlpha +
                            dstBuffer[dstPixelOffset + 0] *
                                normalizedAlphaComplement
                    );
              Severity: Minor
              Found in src/util/composite.ts and 1 other location - About 55 mins to fix
              src/util/composite.ts on lines 126..130

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function doAffineTransformation has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  dstImage: IThAWImage,
    srcImage: IThAWImage,
    matrix: IAffineTransformationMatrix,
    dstLeft?: number,
    dstRight?: number,
              Severity: Major
              Found in src/processing/affine.ts - About 50 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    dstBuffer[dstPixelOffset + 3] = Math.round(
                        srcBuffer[srcPixelOffset + 3] * normalizedAlpha +
                            dstBuffer[dstPixelOffset + 3] *
                                normalizedAlphaComplement
                    );
                Severity: Minor
                Found in src/util/composite.ts and 1 other location - About 50 mins to fix
                src/util/composite.ts on lines 131..135

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    dstBuffer[dstPixelOffset + 1] = Math.round(
                        srcBuffer[srcPixelOffset + 1] * normalizedAlpha +
                            dstBuffer[dstPixelOffset + 1] *
                                normalizedAlphaComplement
                    );
                Severity: Minor
                Found in src/util/composite.ts and 1 other location - About 50 mins to fix
                src/util/composite.ts on lines 120..124

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function generateTestImage_SingleRGBAColour has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    width: number,
    height: number,
    red: number,
    green: number,
    blue: number,
                Severity: Minor
                Found in src/util/composite.ts - About 45 mins to fix

                  Function dispatchRotate90DegreesClockwise has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                  async function dispatchRotate90DegreesClockwise(
    argv: string[]
): Promise<void> {
    let srcFilePath = defaultSrcFilePath;
    let dstFilePath = `test/output-files/rotate90cw.${dstFileExtension}`;
                  Severity: Minor
                  Found in src/cli.ts - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 3 locations. Consider refactoring.
                  Open

                  function resample1DBilinear(
    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
                  Severity: Major
                  Found in src/processing/resample.ts and 2 other locations - About 45 mins to fix
                  src/processing/resample.ts on lines 61..101
                  src/processing/resample.ts on lines 214..316

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Avoid deeply nested control flow statements.
                  Open

                                      switch (srcImage.bytesPerPixel) {
                        case 4:
                            dstImage.data[dstPixelOffset2 + 3] = result3;
                        case 3:
                            dstImage.data[dstPixelOffset2 + 2] = result2;
                  Severity: Major
                  Found in src/processing/pixelate.ts - About 45 mins to fix

                    Function dispatchRotate90DegreesCounterclockwise has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    async function dispatchRotate90DegreesCounterclockwise(
    argv: string[]
): Promise<void> {
    let srcFilePath = defaultSrcFilePath;
    let dstFilePath = `test/output-files/rotate90ccw.${dstFileExtension}`;
                    Severity: Minor
                    Found in src/cli.ts - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                    function resample1DNearestNeighbour(
    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
                    Severity: Major
                    Found in src/processing/resample.ts and 2 other locations - About 45 mins to fix
                    src/processing/resample.ts on lines 103..175
                    src/processing/resample.ts on lines 214..316

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 50.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                    function resample1DBicubic(
    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
                    Severity: Major
                    Found in src/processing/resample.ts and 2 other locations - About 45 mins to fix
                    src/processing/resample.ts on lines 61..101
                    src/processing/resample.ts on lines 103..175

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 50.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function dispatchRotate180Degrees has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    async function dispatchRotate180Degrees(argv: string[]): Promise<void> {
    let srcFilePath = defaultSrcFilePath;
    let dstFilePath = `test/output-files/rotate180.${dstFileExtension}`;

    for (let i = 0; i < argv.length; i++) {
                    Severity: Minor
                    Found in src/cli.ts - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language