Sign upLogin

tom-weatherhead/thaw-image-processing.ts

View on GitHub
Star
src/processing/resample.ts

Summary

Maintainability
F
3 days
Test Coverage

File resample.ts has 309 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// thaw-image-processing.ts/src/resample.ts

// See http://entropymine.com/imageworsener/bicubic/ :

// Cubic resampling
Severity: Minor
Found in src/processing/resample.ts - About 3 hrs to fix

    Function resample1DBicubic has 84 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function resample1DBicubic(
    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
    Severity: Major
    Found in src/processing/resample.ts - About 3 hrs to fix

      Function resample1DBilinear has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function resample1DBilinear(
    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
      Severity: Major
      Found in src/processing/resample.ts - About 2 hrs to fix

        Function resample1DBicubic has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

        function resample1DBicubic(
    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
        Severity: Minor
        Found in src/processing/resample.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function resampleImage has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function resampleImage(
    srcImage: IThAWImage,
    dstWidth: number,
    dstHeight: number,
    mode: number
        Severity: Minor
        Found in src/processing/resample.ts - About 1 hr to fix

          Function resample1DNearestNeighbour has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
    srcBuffer: ThAWImageBufferType,
          Severity: Major
          Found in src/processing/resample.ts - About 1 hr to fix

            Function resample1DBilinear has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
    srcBuffer: ThAWImageBufferType,
            Severity: Major
            Found in src/processing/resample.ts - About 1 hr to fix

              Function resample1DBicubic has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
    srcBuffer: ThAWImageBufferType,
              Severity: Major
              Found in src/processing/resample.ts - About 1 hr to fix

                Function resample1DBilinear has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                function resample1DBilinear(
    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
                Severity: Minor
                Found in src/processing/resample.ts - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function resample1DNearestNeighbour has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function resample1DNearestNeighbour(
    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
                Severity: Minor
                Found in src/processing/resample.ts - About 1 hr to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              switch (numBytesPerPixel) {
                case 4:
                    dstBuffer[dstInitialOffset + 3] =
                        srcBuffer[srcPixelIndex + 3];
                case 3:
                  Severity: Major
                  Found in src/processing/resample.ts and 1 other location - About 3 hrs to fix
                  src/processing/resample.ts on lines 83..96

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          switch (numBytesPerPixel) {
            case 4:
                dstBuffer[dstInitialOffset + 3] =
                    srcBuffer[srcPixelIndex + 3];
            case 3:
                  Severity: Major
                  Found in src/processing/resample.ts and 1 other location - About 3 hrs to fix
                  src/processing/resample.ts on lines 126..139

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 3 locations. Consider refactoring.
                  Open

                  function resample1DBilinear(
    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
                  Severity: Major
                  Found in src/processing/resample.ts and 2 other locations - About 45 mins to fix
                  src/processing/resample.ts on lines 61..101
                  src/processing/resample.ts on lines 214..316

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 3 locations. Consider refactoring.
                  Open

                  function resample1DBicubic(
    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
                  Severity: Major
                  Found in src/processing/resample.ts and 2 other locations - About 45 mins to fix
                  src/processing/resample.ts on lines 61..101
                  src/processing/resample.ts on lines 103..175

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 3 locations. Consider refactoring.
                  Open

                  function resample1DNearestNeighbour(
    dstBuffer: ThAWImageBufferType,
    dstInitialOffset: number,
    numDstPixels: number,
    dstPixelStride: number,
                  Severity: Major
                  Found in src/processing/resample.ts and 2 other locations - About 45 mins to fix
                  src/processing/resample.ts on lines 103..175
                  src/processing/resample.ts on lines 214..316

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                                      dstBuffer[dstInitialOffset + 1] =
                        (srcBuffer[srcPixelIndex + 1] * weight1 +
                            srcBuffer[srcPixelIndex2 + 1] * weight2) /
                        numDstPixels;
                  Severity: Minor
                  Found in src/processing/resample.ts and 2 other locations - About 35 mins to fix
                  src/processing/resample.ts on lines 149..152
                  src/processing/resample.ts on lines 154..157

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 47.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                                      dstBuffer[dstInitialOffset + 2] =
                        (srcBuffer[srcPixelIndex + 2] * weight1 +
                            srcBuffer[srcPixelIndex2 + 2] * weight2) /
                        numDstPixels;
                  Severity: Minor
                  Found in src/processing/resample.ts and 2 other locations - About 35 mins to fix
                  src/processing/resample.ts on lines 149..152
                  src/processing/resample.ts on lines 158..161

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 47.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                                      dstBuffer[dstInitialOffset + 3] =
                        (srcBuffer[srcPixelIndex + 3] * weight1 +
                            srcBuffer[srcPixelIndex2 + 3] * weight2) /
                        numDstPixels;
                  Severity: Minor
                  Found in src/processing/resample.ts and 2 other locations - About 35 mins to fix
                  src/processing/resample.ts on lines 154..157
                  src/processing/resample.ts on lines 158..161

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 47.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status