Sign upLogin

tomaj/bank-mails-parser

View on GitHub
Star

Showing 5 of 5 total issues

MailContent has 34 functions (exceeds 20 allowed). Consider refactoring.
Open

class MailContent
{
    private $amount;

    private $accountNumber;
Severity: Minor
Found in src/MailContent.php - About 4 hrs to fix

    Function parse has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public function parse(string $content): ?MailContent
    {
        $mailContent = new MailContent();

        if (empty($content)) {
    Severity: Minor
    Found in src/Parsers/TatraBanka/TatraBankaSimpleMailParser.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function parse(string $content): ?MailContent
    {
        $mailContent = new MailContent();

        $pattern1 = '/(.*) bol zostatok Vasho uctu ([a-zA-Z0-9]+) (zvyseny|znizeny) o ([0-9 ]+,[0-9]+) ([a-zA-Z]+)/m';
    Severity: Major
    Found in src/Parsers/TatraBanka/TatraBankaMailParser.php - About 2 hrs to fix

      Function parse has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public function parse(string $content): ?MailContent
    {
        $mailContent = new MailContent();

        $pattern1 = '/(.*) bol zostatok Vasho uctu ([a-zA-Z0-9]+) (zvyseny|znizeny) o ([0-9 ]+,[0-9]+) ([a-zA-Z]+)/m';
      Severity: Minor
      Found in src/Parsers/TatraBanka/TatraBankaMailParser.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function parse(string $content): ?MailContent
    {
        $mailContent = new MailContent();

        if (empty($content)) {
      Severity: Minor
      Found in src/Parsers/TatraBanka/TatraBankaSimpleMailParser.php - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language