Sign upLogin

tombh/peas

View on GitHub
Star
switchboard/server/lib/connection.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method authenticate has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def authenticate
    @current_user = false
    api_key = read_line.strip
    if api_key.length >= 64
      if api_key == Setting.retrieve('peas.switchboard_key')
Severity: Minor
Found in switchboard/server/lib/connection.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method dispatch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def dispatch
    _, @port, @host = @socket.peeraddr
    debug "Received connection (ID: #{@socket.object_id}) from #{@host}:#{@port}"

    return unless authenticate
Severity: Minor
Found in switchboard/server/lib/connection.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method close has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def close(type = :normal)
    unless @socket.closed?
      info "Closing connection (ID: #{@socket.object_id}) #{'(closed via client)' if type == :detected}"
    end
    @socket.close
Severity: Minor
Found in switchboard/server/lib/connection.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status