tomography/xdesign

View on GitHub

Showing 54 of 127 total issues

Function contains has a Cognitive Complexity of 75 (exceeds 5 allowed). Consider refactoring.
Open

    def contains(self, other):
        """Return whether this Polygon contains the other."""

        if isinstance(other, Point):
            x = other._x
Severity: Minor
Found in src/xdesign/geometry/area.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function contains has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    def contains(self, other):
        """Return whether `other` is a proper subset.

        Return one boolean for all geometric entities. Return an array of
        boolean for array input.
Severity: Minor
Found in src/xdesign/geometry/area.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def __init__(self):
        super(Softwood, self).__init__()

        ring_size = 0.5
        ring_offset = np.random.rand()
Severity: Minor
Found in src/xdesign/phantom/custom.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function plot_phantom has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

def plot_phantom(
    phantom,
    axis=None,
    labels=None,
    c_props=[],
Severity: Minor
Found in src/xdesign/plot.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function compute_nps_ffst has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

def compute_nps_ffst(phantom, A, B=None, plot_type='frequency'):
    """Calculate the noise power spectrum from a unit circle image using the
    method from :cite:`Friedman:13`.

    Parameters
Severity: Minor
Found in src/xdesign/metrics/standards.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function compute_mtf_ffst has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

def compute_mtf_ffst(phantom, image, Ntheta=4):
    """Calculate the MTF using the method described in :cite:`Friedman:13`.

    .. seealso::

Severity: Minor
Found in src/xdesign/metrics/standards.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sirt has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

def sirt(
    gmin,
    gsize,
    data,
    theta,
Severity: Minor
Found in src/xdesign/recon.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sprinkle has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def sprinkle(
        self,
        counts,
        radius,
        gap=0,
Severity: Minor
Found in src/xdesign/phantom/phantom.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function append has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def append(self, child):
        """Add a child to the Phantom.

        Only add the child if it is contained within the geometry of its
        ancestors.
Severity: Minor
Found in src/xdesign/phantom/phantom.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function art has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

def art(
    gmin,
    gsize,
    data,
    theta,
Severity: Minor
Found in src/xdesign/recon.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def __init__(self, count=10, angle=5 / 360 * 2 * PI, gap=0):
        super(SlantedSquares, self).__init__()
        if count < 1:
            raise ValueError("There must be at least one square.")

Severity: Minor
Found in src/xdesign/phantom/standards.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function clip_SH has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def clip_SH(clipEdges, polygon):
    """Clip a polygon using the Sutherland-Hodgeman algorithm.

    Parameters
    ----------
Severity: Minor
Found in src/xdesign/geometry/intersect.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function combine_grid has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def combine_grid(Amin, A, Bmin, B):
    """Add grid B to grid A by aligning min corners and clipping B

    Parameters
    ----------
Severity: Minor
Found in src/xdesign/plot.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function compute_mtf_ffst has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def compute_mtf_ffst(phantom, image, Ntheta=4):
    """Calculate the MTF using the method described in :cite:`Friedman:13`.

    .. seealso::

Severity: Minor
Found in src/xdesign/metrics/standards.py - About 1 hr to fix

    Function beamcirc has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def beamcirc(beam, circle):
        """Intersection area of a Beam (line with finite thickness) and a circle.
    
        Reference
        ---------
    Severity: Minor
    Found in src/xdesign/acquisition.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function contains has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def contains(self, other):
            """Return whether this Mesh contains other.
    
            FOR ALL `x`,
            THERE EXISTS a face of the Mesh that contains `x`
    Severity: Minor
    Found in src/xdesign/geometry/area.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _collision has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def _collision(phantom, entity):
        """Return the max overlap of the entity and a child of this Phantom.
    
            May return overlap < 0; the distance between the two non-overlapping
            circles.
    Severity: Minor
    Found in src/xdesign/phantom/phantom.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function is_prime has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    def is_prime(n):
        """Return True if n is prime."""
        if n == 2 or n == 3:
            return True
        if n < 2 or n % 2 == 0:
    Severity: Minor
    Found in src/xdesign/codes.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function plot_histograms has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    def plot_histograms(images, masks=None, thresh=0.025):
        """Plot the normalized histograms for the pixel intensity under each
        mask.
    
        Parameters
    Severity: Minor
    Found in src/xdesign/plot.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function mlem has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    def mlem(gmin, gsize, data, theta, h, init, niter=10):
        """Reconstruct data using MLEM algorithm."""
        assert data.size == theta.size == h.size, "theta, h, must be" \
            "the equal lengths"
        data = data.ravel()
    Severity: Minor
    Found in src/xdesign/recon.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language