Sign upLogin

tomokinakamaru/silverchain

View on GitHub
Star

Showing 85 of 85 total issues

Generator has 55 methods (exceeds 20 allowed). Consider refactoring.
Open

public final class Generator {

  private final Diagrams diagrams;

  private final Javadocs javadocs;
Severity: Major
Found in src/main/java/silverchain/generator/Generator.java - About 7 hrs to fix

    ASTBuilder has 52 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public final class ASTBuilder extends AgBaseVisitor<ASTNode> {

  private final Map<String, RuleExpression> fragments = new HashMap<>();

  @Override
    Severity: Major
    Found in src/main/java/silverchain/parser/adapter/ASTBuilder.java - About 7 hrs to fix

      File ASTBuilder.java has 420 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      package silverchain.parser.adapter;

import java.util.HashMap;
import java.util.Map;
import org.antlr.v4.runtime.Token;
      Severity: Minor
      Found in src/main/java/silverchain/parser/adapter/ASTBuilder.java - About 6 hrs to fix

        File Generator.java has 352 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        package silverchain.generator;

import static java.lang.String.join;
import static java.util.Collections.emptyList;
import static java.util.stream.Collectors.joining;
        Severity: Minor
        Found in src/main/java/silverchain/generator/Generator.java - About 4 hrs to fix

          File Tests.java has 285 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          package diagram;

import static org.assertj.core.api.Assertions.assertThat;

import java.io.ByteArrayInputStream;
          Severity: Minor
          Found in src/test/java/diagram/Tests.java - About 2 hrs to fix

            Javadocs has 22 methods (exceeds 20 allowed). Consider refactoring.
            Open

            public final class Javadocs {

  private final String path;

  private final WarningHandler handler;
            Severity: Minor
            Found in src/main/java/silverchain/javadoc/Javadocs.java - About 2 hrs to fix

              Method bulkTestData has 58 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                static Arguments[] bulkTestData() {
    return new Arguments[] {
      args(AgParser::qualifiedName, "foo"),
      args(AgParser::qualifiedName, "foo.bar"),
      args(AgParser::qualifiedName, "foo.bar.baz"),
              Severity: Major
              Found in src/test/java/parser/Tests.java - About 2 hrs to fix

                File Javadocs.java has 257 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                package silverchain.javadoc;

import static java.util.Arrays.stream;
import static java.util.stream.Collectors.joining;
                Severity: Minor
                Found in src/main/java/silverchain/javadoc/Javadocs.java - About 2 hrs to fix

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                    @Test
  void test8() {
    test("Foo { Qux bar(Bar bar) | baz(Baz baz); }")
        .name("Foo")
        .typeParameterCount(0)
                  Severity: Major
                  Found in src/test/java/diagram/Tests.java and 2 other locations - About 1 hr to fix
                  src/test/java/diagram/Tests.java on lines 68..88
                  src/test/java/diagram/Tests.java on lines 185..205

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 117.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                    @Test
  void test10() {
    test("Foo { Qux bar(Bar bar); Qux baz(Baz baz); }")
        .name("Foo")
        .typeParameterCount(0)
                  Severity: Major
                  Found in src/test/java/diagram/Tests.java and 2 other locations - About 1 hr to fix
                  src/test/java/diagram/Tests.java on lines 68..88
                  src/test/java/diagram/Tests.java on lines 144..164

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 117.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                    @Test
  void test4() {
    test("Foo { Baz bar(Bar bar) baz(Baz baz)*; }")
        .name("Foo")
        .typeParameterCount(0)
                  Severity: Major
                  Found in src/test/java/diagram/Tests.java and 2 other locations - About 1 hr to fix
                  src/test/java/diagram/Tests.java on lines 144..164
                  src/test/java/diagram/Tests.java on lines 185..205

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 117.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method generateState has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    private void generateState(State state) {
    beginFile(getFilePath(getStateQualifiedName(state)));
    writePackageDeclaration(getStatePackageName(state));

    // Class declaration
                  Severity: Minor
                  Found in src/main/java/silverchain/generator/Generator.java - About 1 hr to fix

                    Method generateIAction has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      private void generateIAction(Diagram diagram) {
    beginFile(getFilePath(getIActionQualifiedName(diagram)));
    writePackageDeclaration(getIActionPackageName(diagram));

    // Interface declaration
                    Severity: Minor
                    Found in src/main/java/silverchain/generator/Generator.java - About 1 hr to fix

                      Method test12 has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        @Test
  void test12() {
    test("Foo<T;S> { Qux bar(T t) baz(S s)*; }")
        .name("Foo")
        .typeParameterCount(2)
                      Severity: Minor
                      Found in src/test/java/diagram/Tests.java - About 1 hr to fix

                        Method importMap has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                        Open

                          public Map<String, QualifiedName> importMap() {
    Map<String, QualifiedName> map = new HashMap<>();
    if (importStatements().isPresent()) {
      for (ImportStatement i : importStatements().get()) {
        QualifiedName fullName = i.qualifiedName();
                        Severity: Minor
                        Found in src/main/java/silverchain/parser/Input.java - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method test11 has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          @Test
  void test11() {
    test("Foo<T;S> { Qux<T,S> bar(T t) baz(S s); }")
        .name("Foo")
        .typeParameterCount(2)
                        Severity: Minor
                        Found in src/test/java/diagram/Tests.java - About 1 hr to fix

                          Similar blocks of code found in 13 locations. Consider refactoring.
                          Open

                            @Override
  public Type visitClassDeclarationHead(AgParser.ClassDeclarationHeadContext ctx) {
    QualifiedName n = visitQualifiedName(ctx.qualifiedName());
    TypeParameters ps = null;
    if (ctx.classTypeParameterDeclarations() != null) {
                          Severity: Major
                          Found in src/main/java/silverchain/parser/adapter/ASTBuilder.java and 12 other locations - About 55 mins to fix
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 45..53
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 78..86
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 146..154
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 156..164
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 166..174
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 176..184
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 186..194
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 233..241
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 331..339
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 354..362
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 364..372
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 411..419

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 66.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 13 locations. Consider refactoring.
                          Open

                            @Override
  public RuleExpression visitRuleExpression(AgParser.RuleExpressionContext ctx) {
    RuleTerm t = visitRuleTerm(ctx.ruleTerm());
    RuleExpression e = null;
    if (ctx.ruleExpression() != null) {
                          Severity: Major
                          Found in src/main/java/silverchain/parser/adapter/ASTBuilder.java and 12 other locations - About 55 mins to fix
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 45..53
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 78..86
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 102..110
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 146..154
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 156..164
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 176..184
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 186..194
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 233..241
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 331..339
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 354..362
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 364..372
                          src/main/java/silverchain/parser/adapter/ASTBuilder.java on lines 411..419

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 66.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                            private static Diagrams compile(InputStream stream) {
    Diagrams diagrams = new Diagrams();
    Input input = parse(stream);
    for (Grammar grammar : input.grammars()) {
      Diagram diagram = grammar.diagram(input.importMap());
                          Severity: Minor
                          Found in src/test/java/generator/Utility.java and 1 other location - About 55 mins to fix
                          src/test/java/validator/Utility.java on lines 20..29

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 66.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                            private static Diagrams compile(InputStream stream) {
    Diagrams diagrams = new Diagrams();
    Input input = parse(stream);
    for (Grammar grammar : input.grammars()) {
      Diagram diagram = grammar.diagram(input.importMap());
                          Severity: Minor
                          Found in src/test/java/validator/Utility.java and 1 other location - About 55 mins to fix
                          src/test/java/generator/Utility.java on lines 36..45

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 66.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language