tomverran/robots

View on GitHub

Showing 4 of 4 total issues

Function parseFile has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    private function parseFile(RobotsFile $robotFile)
    {
        $emptyRecord = [
            'rules' => [],
            'ua' => []
Severity: Minor
Found in src/Robot/RobotsTxt.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parseFile has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function parseFile(RobotsFile $robotFile)
    {
        $emptyRecord = [
            'rules' => [],
            'ua' => []
Severity: Minor
Found in src/Robot/RobotsTxt.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return empty($matching) || reset($matching)->isAllowed($userAgent, $path);
    Severity: Major
    Found in src/Robot/RobotsTxt.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return $r2->getMatchStrength($userAgent) - $r1->getMatchStrength($userAgent);
      Severity: Major
      Found in src/Robot/RobotsTxt.php - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language