Sign upLogin

toothrot/amplitude-api

View on GitHub
Star
lib/amplitude_api/event.rb

Summary

Maintainability
A
50 mins
Test Coverage

Method optional_properties has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def optional_properties
      AmplitudeAPI::Config.optional_properties.map do |prop|
        val = prop == :time ? formatted_time : send(prop)
        val ? [prop, val] : nil
      end.compact.to_h
Severity: Minor
Found in lib/amplitude_api/event.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_required_arguments has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_required_arguments
      raise ArgumentError, "You must provide user_id or device_id (or both)" unless user_id || device_id
      raise ArgumentError, "You must provide event_type" unless event_type
      raise ArgumentError, "Invalid event_type - cannot match a reserved event name" if reserved_event?(event_type)
    end
Severity: Minor
Found in lib/amplitude_api/event.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status