Sign upLogin

topfreegames/khan

View on GitHub
Star
api/app.go

Summary

Maintainability
D
2 days
Test Coverage

File app.go has 580 lines of code (exceeds 500 allowed). Consider refactoring.
Open

// khan
// https://github.com/topfreegames/khan
//
// Licensed under the MIT license:
// http://www.opensource.org/licenses/mit-license
Severity: Minor
Found in api/app.go - About 3 hrs to fix

    App has 31 methods (exceeds 20 allowed). Consider refactoring.
    Open

    type App struct {
    ID                  string
    Test                bool
    Debug               bool
    Port                int
    Severity: Minor
    Found in api/app.go - About 3 hrs to fix

      Method App.configureApplication has 58 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (app *App) configureApplication() {
    app.Engine = standard.New(fmt.Sprintf("%s:%d", app.Host, app.Port))
    if app.Fast {
        engine := fasthttp.New(fmt.Sprintf("%s:%d", app.Host, app.Port))
        engine.ReadBufferSize = app.ReadBufferSize
      Severity: Minor
      Found in api/app.go - About 1 hr to fix

        Function GetApp has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func GetApp(host string, port int, configPath string, debug bool, logger zap.Logger, fast, test bool) *App {
        Severity: Minor
        Found in api/app.go - About 45 mins to fix

          Method App.Rollback has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (app *App) Rollback(tx gorp.Transaction, msg string, c echo.Context, logger zap.Logger, err error) error {
          Severity: Minor
          Found in api/app.go - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (app *App) connectDatabase() {
    host := app.Config.GetString("postgres.host")
    user := app.Config.GetString("postgres.user")
    dbName := app.Config.GetString("postgres.dbname")
    password := app.Config.GetString("postgres.password")
            Severity: Major
            Found in api/app.go and 1 other location - About 5 hrs to fix
            services/encryption_script.go on lines 90..127

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 406.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (app *App) loadConfiguration() {
    logger := app.Logger.With(
        zap.String("source", "app"),
        zap.String("operation", "loadConfiguration"),
        zap.String("configPath", app.ConfigPath),
            Severity: Major
            Found in api/app.go and 1 other location - About 3 hrs to fix
            services/encryption_script.go on lines 66..88

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 263.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Your code does not pass gofmt in 6 places. Go fmt your code!
            Open

            // khan
            Severity: Minor
            Found in api/app.go by gofmt

            There are no issues that match your filters.

            Category
            Status