Sign upLogin

topfreegames/khan

View on GitHub
Star
api/clan.go

Summary

Maintainability
F
3 days
Test Coverage

File clan.go has 740 lines of code (exceeds 500 allowed). Consider refactoring.
Open

// khan
// https://github.com/topfreegames/khan
//
// Licensed under the MIT license:
// http://www.opensource.org/licenses/mit-license
Severity: Minor
Found in api/clan.go - About 7 hrs to fix

    Function RetrieveClanHandler has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
    Open

    func RetrieveClanHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "RetrieveClan")
        start := time.Now()
        gameID := c.Param("gameID")
    Severity: Minor
    Found in api/clan.go - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function CreateClanHandler has 98 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func CreateClanHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "CreateClan")
        start := time.Now()
        gameID := c.Param("gameID")
    Severity: Major
    Found in api/clan.go - About 2 hrs to fix

      Function RetrieveClanHandler has 94 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func RetrieveClanHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "RetrieveClan")
        start := time.Now()
        gameID := c.Param("gameID")
      Severity: Major
      Found in api/clan.go - About 2 hrs to fix

        Function TransferOwnershipHandler has 91 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func TransferOwnershipHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "TransferClanOwnership")
        start := time.Now()
        gameID := c.Param("gameID")
        Severity: Major
        Found in api/clan.go - About 2 hrs to fix

          Function LeaveClanHandler has 90 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func LeaveClanHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "LeaveClan")
        start := time.Now()
        gameID := c.Param("gameID")
          Severity: Major
          Found in api/clan.go - About 2 hrs to fix

            Function UpdateClanHandler has 84 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func UpdateClanHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "UpdateClan")
        start := time.Now()
        gameID := c.Param("gameID")
            Severity: Major
            Found in api/clan.go - About 2 hrs to fix

              Function RetrieveClansSummariesHandler has 59 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func RetrieveClansSummariesHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "RetrieveClansSummaries")
        start := time.Now()
        gameID := c.Param("gameID")
              Severity: Minor
              Found in api/clan.go - About 1 hr to fix

                Function LeaveClanHandler has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
                Open

                func LeaveClanHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "LeaveClan")
        start := time.Now()
        gameID := c.Param("gameID")
                Severity: Minor
                Found in api/clan.go - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function CreateClanHandler has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                Open

                func CreateClanHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "CreateClan")
        start := time.Now()
        gameID := c.Param("gameID")
                Severity: Minor
                Found in api/clan.go - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function TransferOwnershipHandler has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                Open

                func TransferOwnershipHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "TransferClanOwnership")
        start := time.Now()
        gameID := c.Param("gameID")
                Severity: Minor
                Found in api/clan.go - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if maxPendingApplications != "" {
            maxApps, err := strconv.ParseUint(maxPendingApplications, 10, 16)
            if err != nil {
                return FailWith(400, err.Error(), c)
            }
                Severity: Minor
                Found in api/clan.go and 1 other location - About 35 mins to fix
                api/clan.go on lines 630..639

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if maxPendingInvites != "" {
            maxInvs, err := strconv.ParseUint(maxPendingInvites, 10, 16)
            if err != nil {
                return FailWith(400, err.Error(), c)
            }
                Severity: Minor
                Found in api/clan.go and 1 other location - About 35 mins to fix
                api/clan.go on lines 620..629

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Your code does not pass gofmt in 1 place. Go fmt your code!
                Open

                // khan
                Severity: Minor
                Found in api/clan.go by gofmt

                There are no issues that match your filters.

                Category
                Status