Sign upLogin

topfreegames/khan

View on GitHub
Star
api/clan_helpers.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function validateUpdateClanDispatch has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func validateUpdateClanDispatch(game *models.Game, sourceClan *models.Clan, clan *models.Clan, metadata map[string]interface{}, logger zap.Logger) bool {
Severity: Minor
Found in api/clan_helpers.go - About 35 mins to fix

    Function dispatchClanOwnershipChangeHook has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func dispatchClanOwnershipChangeHook(app *App, hookType int, clan *models.Clan, previousOwner *models.Player, newOwner *models.Player) error {
    Severity: Minor
    Found in api/clan_helpers.go - About 35 mins to fix

      Function validateUpdateClanDispatch has 5 return statements (exceeds 4 allowed).
      Open

      func validateUpdateClanDispatch(game *models.Game, sourceClan *models.Clan, clan *models.Clan, metadata map[string]interface{}, logger zap.Logger) bool {
    cl := logger.With(
        zap.String("clanUpdateMetadataFieldsHookTriggerWhitelist", game.ClanUpdateMetadataFieldsHookTriggerWhitelist),
    )
      Severity: Major
      Found in api/clan_helpers.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for _, field := range fields {
        oldVal, existsOld := sourceClan.Metadata[field]
        newVal, existsNew := metadata[field]
        log.D(logger, "Verifying field for change...", func(cm log.CM) {
            cm.Write(
        Severity: Major
        Found in api/clan_helpers.go and 1 other location - About 3 hrs to fix
        api/player_helpers.go on lines 41..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 254.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status