Sign upLogin

topfreegames/khan

View on GitHub
Star
api/membership.go

Summary

Maintainability
F
3 days
Test Coverage

File membership.go has 560 lines of code (exceeds 500 allowed). Consider refactoring.
Open

// khan
// https://github.com/topfreegames/khan
//
// Licensed under the MIT license:
// http://www.opensource.org/licenses/mit-license
Severity: Minor
Found in api/membership.go - About 3 hrs to fix

    Function ApproveOrDenyMembershipApplicationHandler has 111 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func ApproveOrDenyMembershipApplicationHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "ApproverOrDenyApplication")
        start := time.Now()
        action := c.Param("action")
    Severity: Major
    Found in api/membership.go - About 3 hrs to fix

      Function ApproveOrDenyMembershipInvitationHandler has 93 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func ApproveOrDenyMembershipInvitationHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        var membership *models.Membership
        var err error
        var tx interfaces.Transaction
      Severity: Major
      Found in api/membership.go - About 2 hrs to fix

        Function InviteForMembershipHandler has 93 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func InviteForMembershipHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        var payload InviteForMembershipPayload
        var optional *membershipOptionalParams
        var err error
        Severity: Major
        Found in api/membership.go - About 2 hrs to fix

          Function ApplyForMembershipHandler has 93 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func ApplyForMembershipHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "ApplyForMembership")
        start := time.Now()
        gameID := c.Param("gameID")
          Severity: Major
          Found in api/membership.go - About 2 hrs to fix

            Function DeleteMembershipHandler has 80 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func DeleteMembershipHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "DeleteMembership")
        start := time.Now()
        clanPublicID := c.Param("clanPublicID")
            Severity: Major
            Found in api/membership.go - About 2 hrs to fix

              Function PromoteOrDemoteMembershipHandler has 68 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func PromoteOrDemoteMembershipHandler(app *App, action string) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "PromoteOrDemoteMember")
        start := time.Now()
        clanPublicID := c.Param("clanPublicID")
              Severity: Minor
              Found in api/membership.go - About 1 hr to fix

                Function ApproveOrDenyMembershipApplicationHandler has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
                Open

                func ApproveOrDenyMembershipApplicationHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "ApproverOrDenyApplication")
        start := time.Now()
        action := c.Param("action")
                Severity: Minor
                Found in api/membership.go - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function ApproveOrDenyMembershipInvitationHandler has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
                Open

                func ApproveOrDenyMembershipInvitationHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        var membership *models.Membership
        var err error
        var tx interfaces.Transaction
                Severity: Minor
                Found in api/membership.go - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if err != nil {
            log.E(logger, "Could not dispatch membership hook by id", func(cm log.CM) {
                cm.Write(zap.Error(err))
            })
                Severity: Major
                Found in api/membership.go and 1 other location - About 2 hrs to fix
                api/membership.go on lines 218..234

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 203.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if err != nil {
            log.E(logger, "Could not dispatch membership hook by id", func(cm log.CM) {
                cm.Write(zap.Error(err))
            })
                Severity: Major
                Found in api/membership.go and 1 other location - About 2 hrs to fix
                api/membership.go on lines 103..119

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 203.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if err != nil {
            log.E(logger, "Could not dispatch membership hook by public id", func(cm log.CM) {
                cm.Write(zap.Error(err))
            })
                Severity: Major
                Found in api/membership.go and 1 other location - About 2 hrs to fix
                api/membership.go on lines 352..368

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 195.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if err != nil {
            log.E(logger, "Could not dispatch approve deny membership by id", func(cm log.CM) {
                cm.Write(zap.Error(err))
            })
                Severity: Major
                Found in api/membership.go and 1 other location - About 2 hrs to fix
                api/membership.go on lines 566..582

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 195.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if err != nil {
            log.E(logger, "Could not approve or deny membership invitation", func(cm log.CM) {
                cm.Write(zap.Error(err))
            })
                Severity: Major
                Found in api/membership.go and 1 other location - About 1 hr to fix
                api/membership.go on lines 304..316

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 135.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if err != nil {
            log.E(logger, "Could not approve or deny membership application", func(cm log.CM) {
                cm.Write(zap.Error(err))
            })
                Severity: Major
                Found in api/membership.go and 1 other location - About 1 hr to fix
                api/membership.go on lines 445..458

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 135.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status