Sign upLogin

topfreegames/khan

View on GitHub
Star
api/payload.go

Summary

Maintainability
C
1 day
Test Coverage

Method CreateGamePayload.Validate has 7 return statements (exceeds 4 allowed).
Open

func (p *CreateGamePayload) Validate() []string {
    v := NewValidation()

    var minMembershipLevel int
Severity: Major
Found in api/payload.go - About 45 mins to fix

    Method UpdateGamePayload.Validate has 7 return statements (exceeds 4 allowed).
    Open

    func (p *UpdateGamePayload) Validate() []string {
    v := NewValidation()

    var minMembershipLevel int
    Severity: Major
    Found in api/payload.go - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (p *CreateGamePayload) Validate() []string {
    v := NewValidation()

    var minMembershipLevel int
      Severity: Major
      Found in api/payload.go and 1 other location - About 5 hrs to fix
      api/payload.go on lines 186..226

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 404.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (p *UpdateGamePayload) Validate() []string {
    v := NewValidation()

    var minMembershipLevel int
      Severity: Major
      Found in api/payload.go and 1 other location - About 5 hrs to fix
      api/payload.go on lines 247..287

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 404.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Your code does not pass gofmt in 21 places. Go fmt your code!
      Open

      // khan
      Severity: Minor
      Found in api/payload.go by gofmt

      There are no issues that match your filters.

      Category
      Status