Sign upLogin

topfreegames/khan

View on GitHub
Star

Showing 425 of 425 total issues

Function SearchClan has 5 return statements (exceeds 4 allowed).
Open

func SearchClan(
    db DB, mongo interfaces.MongoDB, gameID, term string, pageSize int64,
) ([]Clan, error) {
    if term == "" {
        return nil, &EmptySearchTermError{}
Severity: Major
Found in models/clan.go - About 35 mins to fix

    Function LoadJSONPayload has 5 return statements (exceeds 4 allowed).
    Open

    func LoadJSONPayload(payloadStruct interface{}, c echo.Context, logger zap.Logger) error {
    log.D(logger, "Loading payload...")

    data, err := GetRequestBody(c)
    if err != nil {
    Severity: Major
    Found in api/helpers.go - About 35 mins to fix

      Function approveOrDenyMembershipHelper has 5 return statements (exceeds 4 allowed).
      Open

      func approveOrDenyMembershipHelper(db DB, membership *Membership, action string, performer *Player) (*Membership, error) {
    approve := action == approveString
    if approve {
        membership.Approved = true
        membership.ApproverID = sql.NullInt64{Int64: performer.ID, Valid: true}
      Severity: Major
      Found in models/membership.go - About 35 mins to fix

        Function dispatchApproveDenyMembershipHookByID has 5 return statements (exceeds 4 allowed).
        Open

        func dispatchApproveDenyMembershipHookByID(app *App, db models.DB, hookType int, gameID string, clanID, playerID, requestorID, creatorID int64, message, membershipLevel string) error {
    clan, err := models.GetClanByID(db, clanID)
    if err != nil {
        return err
    }
        Severity: Major
        Found in api/membership_helpers.go - About 35 mins to fix

          Function getPlayerMembershipDetails has 5 return statements (exceeds 4 allowed).
          Open

          func getPlayerMembershipDetails(db DB, encryptionKey []byte, gameID, publicID string) (map[string]interface{}, error) {
    player, err := GetPlayerByPublicID(db, encryptionKey, gameID, publicID)
    if err != nil {
        return nil, err
    }
          Severity: Major
          Found in models/player.go - About 35 mins to fix

            Function validateUpdateClanDispatch has 5 return statements (exceeds 4 allowed).
            Open

            func validateUpdateClanDispatch(game *models.Game, sourceClan *models.Clan, clan *models.Clan, metadata map[string]interface{}, logger zap.Logger) bool {
    cl := logger.With(
        zap.String("clanUpdateMetadataFieldsHookTriggerWhitelist", game.ClanUpdateMetadataFieldsHookTriggerWhitelist),
    )
            Severity: Major
            Found in api/clan_helpers.go - About 35 mins to fix

              Function CreateClan has 5 return statements (exceeds 4 allowed).
              Open

              func CreateClan(db DB, encryptionKey []byte, gameID, publicID, name, ownerPublicID string, metadata map[string]interface{}, allowApplication, autoJoin bool, maxClansPerPlayer int) (*Clan, error) {
    player, err := GetPlayerByPublicID(db, encryptionKey, gameID, ownerPublicID)
    if err != nil {
        return nil, err
    }
              Severity: Major
              Found in models/clan.go - About 35 mins to fix

                Function sendTo has 5 return statements (exceeds 4 allowed).
                Open

                func sendTo(method, url string, payload map[string]interface{}) (*http.Response, error) {
    payloadJSON, err := json.Marshal(payload)
    if err != nil {
        return nil, err
    }
                Severity: Major
                Found in bench/helpers.go - About 35 mins to fix

                  Your code does not pass gofmt in 7 places. Go fmt your code!
                  Open

                  // khan
                  Severity: Minor
                  Found in testing/logger.go by gofmt

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if maxPendingApplications != "" {
            maxApps, err := strconv.ParseUint(maxPendingApplications, 10, 16)
            if err != nil {
                return FailWith(400, err.Error(), c)
            }
                  Severity: Minor
                  Found in api/clan.go and 1 other location - About 35 mins to fix
                  api/clan.go on lines 630..639

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 104.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if maxPendingInvites != "" {
            maxInvs, err := strconv.ParseUint(maxPendingInvites, 10, 16)
            if err != nil {
                return FailWith(400, err.Error(), c)
            }
                  Severity: Minor
                  Found in api/clan.go and 1 other location - About 35 mins to fix
                  api/clan.go on lines 620..629

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 104.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func getClanLevelByLevelInt(levelInt int, levels map[string]interface{}) string {
    for k, v := range levels {
        switch v.(type) {
        case float64:
            if int(v.(float64)) == levelInt {
                  Severity: Minor
                  Found in models/clan.go and 1 other location - About 30 mins to fix
                  models/membership.go on lines 680..694

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 102.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func getLevelByLevelInt(levelInt int, levels map[string]interface{}) string {
    for k, v := range levels {
        switch v.(type) {
        case float64:
            if int(v.(float64)) == levelInt {
                  Severity: Minor
                  Found in models/membership.go and 1 other location - About 30 mins to fix
                  models/clan.go on lines 683..697

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 102.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Your code does not pass gofmt in 6 places. Go fmt your code!
                  Open

                  // khan
                  Severity: Minor
                  Found in api/app.go by gofmt

                  Your code does not pass gofmt in 6 places. Go fmt your code!
                  Open

                  // khan
                  Severity: Minor
                  Found in api/middleware.go by gofmt

                  Function CreateClanHandler has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                  Open

                  func CreateClanHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "CreateClan")
        start := time.Now()
        gameID := c.Param("gameID")
                  Severity: Minor
                  Found in api/clan.go - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function UpdatePlayerHandler has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                  Open

                  func UpdatePlayerHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "UpdatePlayer")
        start := time.Now()
        gameID := c.Param("gameID")
                  Severity: Minor
                  Found in api/player.go - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function TransferOwnershipHandler has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                  Open

                  func TransferOwnershipHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "TransferClanOwnership")
        start := time.Now()
        gameID := c.Param("gameID")
                  Severity: Minor
                  Found in api/clan.go - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Your code does not pass gofmt in 4 places. Go fmt your code!
                  Open

                  // khan
                  Severity: Minor
                  Found in models/player.go by gofmt

                  Your code does not pass gofmt in 4 places. Go fmt your code!
                  Open

                  // khan
                  Severity: Minor
                  Found in api/helpers_test.go by gofmt
                  Severity
                  Category
                  Status
                  Source
                  Language