Sign upLogin

topfreegames/khan

View on GitHub
Star
models/clan_easyjson.go

Summary

Maintainability
C
1 day
Test Coverage

Function easyjson91eb9988EncodeGithubComTopfreegamesKhanModels has 86 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func easyjson91eb9988EncodeGithubComTopfreegamesKhanModels(out *jwriter.Writer, in Clan) {
    out.RawByte('{')
    first := true
    _ = first
    {
Severity: Major
Found in models/clan_easyjson.go - About 2 hrs to fix

    Function easyjson91eb9988DecodeGithubComTopfreegamesKhanModels has 71 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func easyjson91eb9988DecodeGithubComTopfreegamesKhanModels(in *jlexer.Lexer, out *Clan) {
    isTopLevel := in.IsStart()
    if in.IsNull() {
        if isTopLevel {
            in.Consumed()
    Severity: Minor
    Found in models/clan_easyjson.go - About 1 hr to fix

      Function easyjson91eb9988DecodeGithubComTopfreegamesKhanModels has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

      func easyjson91eb9988DecodeGithubComTopfreegamesKhanModels(in *jlexer.Lexer, out *Clan) {
    isTopLevel := in.IsStart()
    if in.IsNull() {
        if isTopLevel {
            in.Consumed()
      Severity: Minor
      Found in models/clan_easyjson.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                          if m, ok := v1.(easyjson.Unmarshaler); ok {
                        m.UnmarshalEasyJSON(in)
                    } else if m, ok := v1.(json.Unmarshaler); ok {
                        _ = m.UnmarshalJSON(in.Raw())
                    } else {
      Severity: Major
      Found in models/clan_easyjson.go - About 45 mins to fix

        Similar blocks of code found in 9 locations. Consider refactoring.
        Open

            {
        const prefix string = ",\"metadata\":"
        out.RawString(prefix)
        if in.Metadata == nil && (out.Flags&jwriter.NilMapAsEmpty) == 0 {
            out.RawString(`null`)
        Severity: Major
        Found in models/clan_easyjson.go and 8 other locations - About 3 hrs to fix
        api/payload_easyjson.go on lines 127..153
        api/payload_easyjson.go on lines 270..296
        api/payload_easyjson.go on lines 297..323
        api/payload_easyjson.go on lines 459..485
        api/payload_easyjson.go on lines 754..780
        api/payload_easyjson.go on lines 904..930
        api/payload_easyjson.go on lines 931..957
        api/payload_easyjson.go on lines 1100..1126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 259.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 9 locations. Consider refactoring.
        Open

                case "metadata":
            if in.IsNull() {
                in.Skip()
            } else {
                in.Delim('{')
        Severity: Major
        Found in models/clan_easyjson.go and 8 other locations - About 2 hrs to fix
        api/payload_easyjson.go on lines 86..107
        api/payload_easyjson.go on lines 187..208
        api/payload_easyjson.go on lines 209..230
        api/payload_easyjson.go on lines 409..430
        api/payload_easyjson.go on lines 708..729
        api/payload_easyjson.go on lines 816..837
        api/payload_easyjson.go on lines 838..859
        api/payload_easyjson.go on lines 1045..1066

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 231.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status