File membership.go has 600 lines of code (exceeds 500 allowed). Consider refactoring.

Open

// khan
// https://github.com/topfreegames/khan
//
// Licensed under the MIT license:
// http://www.opensource.org/licenses/mit-license

Function validateMembership has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring.

Open

func validateMembership(db DB, encryptionKey []byte, game *Game, membership *Membership, clan *Clan, playerPublicID, requestorPublicID string) (int64, bool, error) {
    playerID := int64(-1)
    previousMembership := false
    if membership != nil {
        previousMembership = true

• Read up
  Read up

Function validateMembership has 56 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func validateMembership(db DB, encryptionKey []byte, game *Game, membership *Membership, clan *Clan, playerPublicID, requestorPublicID string) (int64, bool, error) {
    playerID := int64(-1)
    previousMembership := false
    if membership != nil {
        previousMembership = true

Function ApproveOrDenyMembershipApplication has 12 return statements (exceeds 4 allowed).

Open

func ApproveOrDenyMembershipApplication(db DB, encryptionKey []byte, game *Game, gameID, playerPublicID, clanPublicID, requestorPublicID, action string) (*Membership, error) {
    if playerPublicID == requestorPublicID {
        return nil, &PlayerCannotPerformMembershipActionError{action, playerPublicID, clanPublicID, requestorPublicID}
    }

Function inviteMember has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

func inviteMember(db DB, encryptionKey []byte, game *Game, membership *Membership, level string, clan *Clan, playerID int64, requestorPublicID, message string, previousMembership bool) (*Membership, error) {

Function inviteMember has 10 return statements (exceeds 4 allowed).

Open

func inviteMember(db DB, encryptionKey []byte, game *Game, membership *Membership, level string, clan *Clan, playerID int64, requestorPublicID, message string, previousMembership bool) (*Membership, error) {
    reqMembership, _ := GetValidMembershipByClanAndPlayerPublicID(db, game.PublicID, clan.PublicID, requestorPublicID)
    if reqMembership == nil {
        requestor, err := GetPlayerByPublicID(db, encryptionKey, game.PublicID, requestorPublicID)
        if err != nil {

Function applyForMembership has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

func applyForMembership(db DB, game *Game, membership *Membership, level string, clan *Clan, playerID int64, requestorPublicID, message string, previousMembership bool) (*Membership, error) {

Function validateMembership has 9 return statements (exceeds 4 allowed).

Open

func validateMembership(db DB, encryptionKey []byte, game *Game, membership *Membership, clan *Clan, playerPublicID, requestorPublicID string) (int64, bool, error) {
    playerID := int64(-1)
    previousMembership := false
    if membership != nil {
        previousMembership = true

Function PromoteOrDemoteMember has 8 return statements (exceeds 4 allowed).

Open

func PromoteOrDemoteMember(db DB, game *Game, gameID, playerPublicID, clanPublicID, requestorPublicID, action string) (*Membership, error) {
    demote := action == "demote"
    promote := action == "promote"

    levelOffset := game.MinLevelOffsetToDemoteMember

Avoid deeply nested control flow statements.

Open

            if cd != 0 {
                timeToBeReady := cd - int(nowInMilliseconds-membership.UpdatedAt)/1000
                if timeToBeReady > 0 {
                    return -1, false, &MustWaitMembershipCooldownError{timeToBeReady, playerPublicID, clan.PublicID}
                }

Function updatePreviousMembershipHelper has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

func updatePreviousMembershipHelper(db DB, membership *Membership, level string, requestorID int64, message string, approved bool) (*Membership, error) {

Function ApproveOrDenyMembershipInvitation has 7 return statements (exceeds 4 allowed).

Open

func ApproveOrDenyMembershipInvitation(db DB, encryptionKey []byte, game *Game, gameID, playerPublicID, clanPublicID, action string) (*Membership, error) {
    membership, err := GetValidMembershipByClanAndPlayerPublicID(db, gameID, clanPublicID, playerPublicID)
    if err != nil {
        return nil, err
    }

Function validateMembership has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

func validateMembership(db DB, encryptionKey []byte, game *Game, membership *Membership, clan *Clan, playerPublicID, requestorPublicID string) (int64, bool, error) {

Avoid deeply nested control flow statements.

Open

            if timeToBeReady > 0 {
                return -1, false, &MustWaitMembershipCooldownError{timeToBeReady, playerPublicID, clan.PublicID}
            }

Avoid deeply nested control flow statements.

Open

            if previousInvite && requestorPublicID != playerPublicID {
                cd = game.CooldownBeforeInvite
            }

Avoid deeply nested control flow statements.

Open

            if !previousInvite && requestorPublicID == playerPublicID && !memberLeft {
                cd = game.CooldownBeforeApply
            }

Function CreateMembership has 6 return statements (exceeds 4 allowed).

Open

func CreateMembership(db DB, encryptionKey []byte, game *Game, gameID, level, playerPublicID, clanPublicID, requestorPublicID, message string) (*Membership, error) {
    if _, levelValid := game.MembershipLevels[level]; !levelValid {
        return nil, &InvalidLevelForGameError{gameID, level}
    }

Function DeleteMembership has 6 return statements (exceeds 4 allowed).

Open

func DeleteMembership(db DB, game *Game, gameID, playerPublicID, clanPublicID, requestorPublicID string) (*Membership, error) {
    membership, err := GetValidMembershipByClanAndPlayerPublicID(db, gameID, clanPublicID, playerPublicID)
    if err != nil {
        return nil, err
    }

Function createMembershipHelper has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func createMembershipHelper(db DB, gameID, level string, playerID, clanID, requestorID int64, message string, approved bool) (*Membership, error) {

Function approveOrDenyMembershipHelper has 5 return statements (exceeds 4 allowed).

Open

func approveOrDenyMembershipHelper(db DB, membership *Membership, action string, performer *Player) (*Membership, error) {
    approve := action == approveString
    if approve {
        membership.Approved = true
        membership.ApproverID = sql.NullInt64{Int64: performer.ID, Valid: true}

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func GetMembershipByClanAndPlayerPublicID(db DB, gameID, clanPublicID, playerPublicID string) (*Membership, error) {
    var memberships []*Membership
    query := `
    SELECT
        m.*

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func GetValidMembershipByClanAndPlayerPublicID(db DB, gameID, clanPublicID, playerPublicID string) (*Membership, error) {
    var memberships []*Membership
    query := `
    SELECT
        m.*

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func getLevelByLevelInt(levelInt int, levels map[string]interface{}) string {
    for k, v := range levels {
        switch v.(type) {
        case float64:
            if int(v.(float64)) == levelInt {

• Read up
  Read up