Sign upLogin

topfreegames/khan

View on GitHub
Star
models/prune.go

Summary

Maintainability
A
3 hrs
Test Coverage

Function PruneStaleData has 53 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func PruneStaleData(options *PruneOptions, db DB, logger zap.Logger) (*PruneStats, error) {
    log.I(logger, "Pruning stale data...", func(cm log.CM) {
        cm.Write(
            zap.String("GameID", options.GameID),
            zap.Int("PendingApplicationsExpiration", options.PendingApplicationsExpiration),
Severity: Minor
Found in models/prune.go - About 1 hr to fix

    Function PruneStaleData has 5 return statements (exceeds 4 allowed).
    Open

    func PruneStaleData(options *PruneOptions, db DB, logger zap.Logger) (*PruneStats, error) {
    log.I(logger, "Pruning stale data...", func(cm log.CM) {
        cm.Write(
            zap.String("GameID", options.GameID),
            zap.Int("PendingApplicationsExpiration", options.PendingApplicationsExpiration),
    Severity: Major
    Found in models/prune.go - About 35 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          log.I(logger, "Pruning stale data...", func(cm log.CM) {
        cm.Write(
            zap.String("GameID", options.GameID),
            zap.Int("PendingApplicationsExpiration", options.PendingApplicationsExpiration),
            zap.Int("PendingInvitesExpiration", options.PendingInvitesExpiration),
      Severity: Major
      Found in models/prune.go and 2 other locations - About 40 mins to fix
      cmd/prune.go on lines 129..137
      models/prune.go on lines 152..160

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          log.I(logger, "Pruned stale data succesfully.", func(cm log.CM) {
        cm.Write(
            zap.String("GameID", options.GameID),
            zap.Int("PendingApplicationsPruned", stats.PendingApplicationsPruned),
            zap.Int("PendingInvitesPruned", stats.PendingInvitesPruned),
      Severity: Major
      Found in models/prune.go and 2 other locations - About 40 mins to fix
      cmd/prune.go on lines 129..137
      models/prune.go on lines 103..111

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Your code does not pass gofmt in 1 place. Go fmt your code!
      Open

      // khan
      Severity: Minor
      Found in models/prune.go by gofmt

      There are no issues that match your filters.

      Category
      Status