topspin/id3_tags

View on GitHub

Showing 2 of 2 total issues

Method new_frame_for has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def new_frame_for(content, frame_id, type)
      return if content.nil?
      case type
      when :string
        TagLib::MP4::Item.from_string_list [content.to_s]
Severity: Minor
Found in lib/id3_tags/m4a/fields_setter.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_string_field has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def get_string_field(value, default = nil)
      string = value && value.to_string_list.first
      if default.present? # then cast to integer (or use default if impossible)
        string ? string.to_i : default
      else
Severity: Minor
Found in lib/id3_tags/m4a/fields_getter.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language