toreta/time_second

View on GitHub
lib/time_second.rb

Summary

Maintainability
A
0 mins
Test Coverage

TimeSecond#+ has the variable name 'l'
Open

    r, l = @time.coerce(other)
Severity: Minor
Found in lib/time_second.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

TimeSecond#- has the variable name 'r'
Open

    r, l = @time.coerce(other)
Severity: Minor
Found in lib/time_second.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

TimeSecond#* has the variable name 'l'
Open

    r, l = @time.coerce(other)
Severity: Minor
Found in lib/time_second.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

TimeSecond#/ has the variable name 'l'
Open

    r, l = @time.coerce(other)
Severity: Minor
Found in lib/time_second.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

TimeSecond#/ has the variable name 'r'
Open

    r, l = @time.coerce(other)
Severity: Minor
Found in lib/time_second.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

TimeSecond#+ has the variable name 'r'
Open

    r, l = @time.coerce(other)
Severity: Minor
Found in lib/time_second.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

TimeSecond#self.parse has the variable name 'h'
Open

    h, m, s = str.split(':')
Severity: Minor
Found in lib/time_second.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

TimeSecond#% has the variable name 'r'
Open

    r, l = @time.coerce(other)
Severity: Minor
Found in lib/time_second.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

TimeSecond#- has the variable name 'l'
Open

    r, l = @time.coerce(other)
Severity: Minor
Found in lib/time_second.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

TimeSecond#self.parse has the variable name 'm'
Open

    h, m, s = str.split(':')
Severity: Minor
Found in lib/time_second.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

TimeSecond#% has the variable name 'l'
Open

    r, l = @time.coerce(other)
Severity: Minor
Found in lib/time_second.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

TimeSecond#* has the variable name 'r'
Open

    r, l = @time.coerce(other)
Severity: Minor
Found in lib/time_second.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

TimeSecond#self.parse has the variable name 's'
Open

    h, m, s = str.split(':')
Severity: Minor
Found in lib/time_second.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Use =~ in places where the MatchData returned by #match will not be used.
Open

    unless str.match(/\A\d{1,2}:\d{2}(?:\:\d{2})?\z/)
Severity: Minor
Found in lib/time_second.rb by rubocop

This cop identifies the use of Regexp#match or String#match, which returns #<MatchData>/nil. The return value of =~ is an integral index/nil and is more performant.

Example:

# bad
do_something if str.match(/regex/)
while regex.match('str')
  do_something
end

# good
method(str =~ /regex/)
return value unless regex =~ 'str'

Freeze mutable objects assigned to constants.
Open

  VERSION = '0.1.0'
Severity: Minor
Found in lib/time_second.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

There are no issues that match your filters.

Category
Status