Function main has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.

Open

def main():
    parser = argparse.ArgumentParser(description='ethtool wannabe')
    parser.add_argument('--json', action=argparse.BooleanOptionalAction)
    parser.add_argument('--show-priv-flags', action=argparse.BooleanOptionalAction)
    parser.add_argument('--set-priv-flags', action=argparse.BooleanOptionalAction)

• Read up
  Read up

File ethtool.py has 336 lines of code (exceeds 250 allowed). Consider refactoring.

Open

#!/usr/bin/env python3
# SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause

import argparse
import json

Function main has 80 lines of code (exceeds 25 allowed). Consider refactoring.

Open

def main():
    parser = argparse.ArgumentParser(description='ethtool wannabe')
    parser.add_argument('--json', action=argparse.BooleanOptionalAction)
    parser.add_argument('--show-priv-flags', action=argparse.BooleanOptionalAction)
    parser.add_argument('--set-priv-flags', action=argparse.BooleanOptionalAction)

Function print_field has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.

Open

def print_field(reply, *desc):
    """
    Pretty-print a set of fields from the reply. desc specifies the
    fields and the optional type (bool/yn).
    """

• Read up
  Read up

Function dumpit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

def dumpit(ynl, args, op_name, extra = {}):
    """
    Prepare request header, parse arguments and dumpit (filtering out the
    devices we're not interested in).
    """

• Read up
  Read up

Avoid too many return statements within this function.

Open

        return

Avoid too many return statements within this function.

Open

        return

Avoid too many return statements within this function.

Open

        return

Avoid too many return statements within this function.

Open

        return

Avoid too many return statements within this function.

Open

        return

Avoid too many return statements within this function.

Open

        return doit(ynl, args, 'rings-set')

Avoid too many return statements within this function.

Open

        return

Avoid too many return statements within this function.

Open

        return

Avoid too many return statements within this function.

Open

        return

Avoid too many return statements within this function.

Open

        return

Avoid too many return statements within this function.

Open

        return

Avoid too many return statements within this function.

Open

        return doit(ynl, args, 'channels-set')

Function args_to_req has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

def args_to_req(ynl, op_name, args, req):
    """
    Verify and convert command-line arguments to the ynl-compatible request.
    """
    valid_attrs = ynl.operation_do_attributes(op_name)

• Read up
  Read up