File jevents.py has 1088 lines of code (exceeds 250 allowed). Consider refactoring.

Open

#!/usr/bin/env python3
# SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
"""Convert directories of JSON events to C code."""
import argparse
import csv

Function __init__ has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.

Open

  def __init__(self, jd: dict):
    """Constructor passed the dictionary of parsed json values."""

    def llx(x: int) -> str:
      """Convert an int to a string similar to a printf modifier of %#llx."""

• Read up
  Read up

Function main has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.

Open

def main() -> None:
  global _args

  def dir_path(path: str) -> str:
    """Validate path is a directory for argparse."""

• Read up
  Read up

Function print_mapping_table has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.

Open

def print_mapping_table(archs: Sequence[str]) -> None:
  """Read the mapfile and generate the struct from cpuid string to event table."""
  _args.output_file.write("""
/* Struct used to make the PMU event table implementation opaque to callers. */
struct pmu_events_table {

• Read up
  Read up

Function print_system_mapping_table has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.

Open

def print_system_mapping_table() -> None:
  """C struct mapping table array for tables from /sys directories."""
  _args.output_file.write("""
struct pmu_sys_events {
\tconst char *name;

• Read up
  Read up

Function compute has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.

Open

  def compute(self) -> None:
    """Called once all strings are added to compute the string and offsets."""

    folded_strings = {}
    # Determine if two strings can be folded, ie. let 1 string use the

• Read up
  Read up

Function build_c_string has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.

Open

  def build_c_string(self, metric: bool) -> str:
    s = ''
    for attr in _json_metric_attributes if metric else _json_event_attributes:
      x = getattr(self, attr)
      if metric and x and attr == 'metric_expr':

• Read up
  Read up

Function __init__ has 49 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def __init__(self, jd: dict):
    """Constructor passed the dictionary of parsed json values."""

    def llx(x: int) -> str:
      """Convert an int to a string similar to a printf modifier of %#llx."""

Function preprocess_arch_std_files has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.

Open

def preprocess_arch_std_files(archpath: str) -> None:
  """Read in all architecture standard events."""
  global _arch_std_events
  for item in os.scandir(archpath):
    if item.is_file() and item.name.endswith('.json'):

• Read up
  Read up

Function print_pending_events has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.

Open

def print_pending_events() -> None:
  """Optionally close events table."""

  def event_cmp_key(j: JsonEvent) -> Tuple[str, str, bool, str, str]:
    def fix_none(s: Optional[str]) -> str:

• Read up
  Read up

Function print_pending_metrics has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.

Open

def print_pending_metrics() -> None:
  """Optionally close metrics table."""

  def metric_cmp_key(j: JsonEvent) -> Tuple[bool, str, str]:
    def fix_none(s: Optional[str]) -> str:

• Read up
  Read up

Function preprocess_one_file has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

Open

def preprocess_one_file(parents: Sequence[str], item: os.DirEntry) -> None:

  if item.is_dir():
    return

• Read up
  Read up

Function process_one_file has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

Open

def process_one_file(parents: Sequence[str], item: os.DirEntry) -> None:
  """Process a JSON file during the main walk."""
  def is_leaf_dir(path: str) -> bool:
    for item in os.scandir(path):
      if item.is_dir():

• Read up
  Read up

Function read_json_events has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

def read_json_events(path: str, topic: str) -> Sequence[JsonEvent]:
  """Read json events from the specified file."""
  try:
    events = json.load(open(path), object_hook=JsonEvent)
  except BaseException as err:

• Read up
  Read up

Avoid deeply nested control flow statements.

Open

          if not first and len(row) > 0 and not row[0].startswith('#'):
            event_tblname = file_name_to_table_name('pmu_events_', [], row[2].replace('/', '_'))
            if event_tblname in _event_tables:
              event_size = f'ARRAY_SIZE({event_tblname})'
            else: